-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc 1.63.1 #2227
Add grpc 1.63.1 #2227
Conversation
Patches are mostly the same as 1.62.1 just rebased. Added new rules_apple and google_benchmark dependencies
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (grpc) have been updated in this PR. Please review the changes. |
I am seeing
But there is no archive like that available from grpc |
Please add the presubmit-auto-run and skip-url-stability-check labels to the PR. Thanks! |
Tests pass! Let me know what else is needed to get this submitted |
have you incorporated the patches in 1.62.1.bcr.2 (see https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/grpc/1.62.1.bcr.2/source.json)? or have they been upstreamed? |
I incorporated all patches from 1.62.1 1.62.1.bcr.1 and 1.62.1.bcr.2. I combined all non MODULE.bazel patches into one patch file. |
Let me double check |
Verifed that all patches from 1.62.1, 1.62.1.bcr.1 and 1.62.1.bcr.2 have been brought forward or upstreamed. I updated the presubmit test to run on mac and windows again (this was removed in 1.62.bcr.2) |
Patches are mostly the same as 1.62.1 just rebased. Added new rules_apple and google_benchmark dependencies