Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc 1.63.1 #2227

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Add grpc 1.63.1 #2227

merged 8 commits into from
Jun 11, 2024

Conversation

bentekkie
Copy link
Contributor

Patches are mostly the same as 1.62.1 just rebased. Added new rules_apple and google_benchmark dependencies

Patches are mostly the same as 1.62.1 just rebased.
Added new rules_apple and google_benchmark dependencies
@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (grpc) have been updated in this PR. Please review the changes.

@bentekkie
Copy link
Contributor Author

I am seeing


[email protected] is using an unstable source url: `https://github.com/grpc/grpc/archive/refs/tags/v1.63.1.tar.gz`.
--
  | You should use a release archive URL in the format of `https://github.com/<ORGANIZATION>/<REPO>/releases/download/<version>/<name>.tar.gz` to ensure the archive checksum stability.
  | See https://blog.bazel.build/2023/02/15/github-archive-checksum.html for more context.

But there is no archive like that available from grpc

@bentekkie
Copy link
Contributor Author

Please add the presubmit-auto-run and skip-url-stability-check labels to the PR. Thanks!

@alexeagle alexeagle added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Jun 10, 2024
@bentekkie
Copy link
Contributor Author

Tests pass! Let me know what else is needed to get this submitted

@Wyverald
Copy link
Member

Patches are mostly the same as 1.62.1 just rebased. Added new rules_apple and google_benchmark dependencies

have you incorporated the patches in 1.62.1.bcr.2 (see https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/grpc/1.62.1.bcr.2/source.json)? or have they been upstreamed?

@bentekkie
Copy link
Contributor Author

I incorporated all patches from 1.62.1 1.62.1.bcr.1 and 1.62.1.bcr.2. I combined all non MODULE.bazel patches into one patch file.

@bentekkie
Copy link
Contributor Author

Let me double check

@bentekkie
Copy link
Contributor Author

Verifed that all patches from 1.62.1, 1.62.1.bcr.1 and 1.62.1.bcr.2 have been brought forward or upstreamed.

I updated the presubmit test to run on mac and windows again (this was removed in 1.62.bcr.2)
@grpc//examples/protos/... only builds on ci on linux. For windows it seems that grpc is expecting a msys/mingw toolchain and for mac there are some missing _PyBytes_ objects for cython. Fixing these seems out of scope for importing the new grpc version as these breakages seem present for 1.62.1 aswell

@fmeum fmeum merged commit 094c372 into bazelbuild:main Jun 11, 2024
12 checks passed
@bentekkie bentekkie deleted the grpcupdate branch June 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants