-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #2265
[email protected] #2265
Conversation
Hello @lalten, modules you maintain (rules_appimage) have been updated in this PR. Please review the changes. |
@lalten The failure looks significant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
Yep, I was too quick to approve. The GitHub Actions CI in rules_appimage has https://github.com/lalten/rules_appimage/blob/1641c92f0b70ac141806ad013109383d0da9f2f6/.github/workflows/ci.yaml#L42, need to add this to the BCR presubmit as well |
Require module maintainers' approval for newly pushed changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
Hmm
How can pass this target pattern to the presubmit CI? 🤔 |
Head branch was pushed to by a user without write access
Require module maintainers' approval for newly pushed changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
Co-authored-by: Fabian Meumertzheim <[email protected]>
Head branch was pushed to by a user without write access
Require module maintainers' approval for newly pushed changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
Release: https://github.com/lalten/rules_appimage/releases/tag/v1.12.0
Automated by Publish to BCR