Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2265

Merged
merged 4 commits into from
Jun 14, 2024
Merged

[email protected] #2265

merged 4 commits into from
Jun 14, 2024

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @lalten, modules you maintain (rules_appimage) have been updated in this PR. Please review the changes.

lalten
lalten previously approved these changes Jun 14, 2024
@fmeum
Copy link
Contributor

fmeum commented Jun 14, 2024

@lalten The failure looks significant

bazel-io
bazel-io previously approved these changes Jun 14, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@lalten
Copy link
Contributor

lalten commented Jun 14, 2024

@lalten The failure looks significant

Yep, I was too quick to approve. The GitHub Actions CI in rules_appimage has https://github.com/lalten/rules_appimage/blob/1641c92f0b70ac141806ad013109383d0da9f2f6/.github/workflows/ci.yaml#L42, need to add this to the BCR presubmit as well

@bazel-io bazel-io dismissed stale reviews from lalten and themself June 14, 2024 13:14

Require module maintainers' approval for newly pushed changes.

lalten
lalten previously approved these changes Jun 14, 2024
bazel-io
bazel-io previously approved these changes Jun 14, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum enabled auto-merge (squash) June 14, 2024 13:32
@lalten
Copy link
Contributor

lalten commented Jun 14, 2024

Hmm

(15:33:16) ERROR: Skipping '//... -//tests/pycross/...': invalid package name '... -//tests/pycross': package names may not contain '//' path separators
  | (15:33:16) ERROR: Failed to parse target pattern even though it was previously parsed successfully: invalid package name '... -//tests/pycross': package names may not contain '//' path separators

How can pass this target pattern to the presubmit CI? 🤔

auto-merge was automatically disabled June 14, 2024 13:51

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed stale reviews from lalten and themself June 14, 2024 13:51

Require module maintainers' approval for newly pushed changes.

lalten
lalten previously approved these changes Jun 14, 2024
@fmeum fmeum enabled auto-merge (squash) June 14, 2024 14:12
bazel-io
bazel-io previously approved these changes Jun 14, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

auto-merge was automatically disabled June 14, 2024 15:06

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed stale reviews from lalten and themself June 14, 2024 15:07

Require module maintainers' approval for newly pushed changes.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum enabled auto-merge (squash) June 14, 2024 15:08
@fmeum fmeum merged commit 5e41566 into bazelbuild:main Jun 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants