Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #3421

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Vertexwahn
Copy link
Contributor

Add boost.beast 1.83.0

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.beast) have been updated in this PR. Please review the changes.

@Vertexwahn
Copy link
Contributor Author

@bazel-io skip_check unstable_url

1 similar comment
@Vertexwahn
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 14, 2024
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 16, 2024
@meteorcloudy
Copy link
Member

Please take a look at the presubmit failures

@Vertexwahn
Copy link
Contributor Author

@wep21 I added you to the maintainer list. I hope this is ok for you. This is still WIP - use boost.beast already in my software builds but struggle to get --process_headers_in_dependencies working. Not sure if --process_headers_in_dependencies make sense at all for boost.beast since many header file seem not to work as "standalone" files. Did also not find a pattern. Still playing around withexcludeandtextual_hdrs. Also thinking about writting a tool that figures out which headers are "standalone" and generates excludeandtextual_hdrs` sections for me...

@wep21
Copy link
Contributor

wep21 commented Dec 23, 2024

@Vertexwahn

I added you to the maintainer list. I hope this is ok for you.

Thanks. It's fine for me.

@fmeum
Copy link
Contributor

fmeum commented Dec 24, 2024

You need to update integrity hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants