Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host an empty zip in the BCR repo #3474

Closed
wants to merge 1 commit into from
Closed

Host an empty zip in the BCR repo #3474

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Dec 21, 2024

This file can be used as the canonical source of modules that consist entirely of overlays and patches. An empty ZIP is very small and using the same source avoids unnecessary network connections due to almost guaranteed remote cache hits.

This file can be used as the canonical source of modules that consist entirely of overlays and patches. An empty ZIP is very small and using the same source avoids unnecessary network connections due to almost guaranteed remote cache hits.
@fmeum
Copy link
Contributor Author

fmeum commented Dec 21, 2024

Could we arrange for this to be hosted as e.g. https://bcr.bazel.build/empty.zip, perhaps backed by mirror.bazel.build?

@Vertexwahn
Copy link
Contributor

Maybe you need to create a mirror request here -> https://github.com/bazelbuild/bazel/issues/new/choose

@fmeum
Copy link
Contributor Author

fmeum commented Dec 30, 2024

Maybe you need to create a mirror request here -> https://github.com/bazelbuild/bazel/issues/new/choose

I do, but I would prefer a "pretty" upstream URL. Once this PR has been merged, I will send a mirror request.

@meteorcloudy
Copy link
Member

Could we arrange for this to be hosted as e.g. https://bcr.bazel.build/empty.zip, perhaps backed by mirror.bazel.build?

Sure,https://bcr.bazel.build/empty.zip is now available! No need to mirror it again, bcr.bazel.build is already basically a mirror the BCR repo backed by a GCS bucket. It should be very stable. We could still check in this PR, but I don't think it's necessary?

@fmeum
Copy link
Contributor Author

fmeum commented Jan 2, 2025

It's not, thanks for the prominent URL!

@fmeum fmeum closed this Jan 2, 2025
@fmeum fmeum deleted the empty-zip branch January 6, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants