Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nanobind_bazel v2.4.0 #3481

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Conversation

nicholasjng
Copy link
Contributor

Mirrors nanobind v2.4.0. Note that no nanobind v2.3.0 was released due to a mistake in the release process.

@nicholasjng
Copy link
Contributor Author

I guess Bazel 6.x can go from the presubmit, but Bazel 7.x now also fails (missing --std="c++17"), which is confusing to me.

Mirrors nanobind v2.4.0. Note that no nanobind v2.3.0 was released
due to a mistake in the release process.
@nicholasjng
Copy link
Contributor Author

nicholasjng commented Dec 24, 2024

Decided to set the test target in the presubmit to the newly exposed @nanobind_bazel//:nanobind, which was the "headline feature" for v2.4.0. This is exactly what the separate @nanobind BCR module does in its presubmit file.

(For clarification: This is an alias pointing to the @nanobind repo extension - it was there since the beginning, because it's the whole point of nanobind_bazel, but it was not accessible by downstream users until this release.)

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 24, 2024
fmeum
fmeum previously approved these changes Dec 24, 2024
@fmeum fmeum enabled auto-merge (squash) December 24, 2024 13:21
@nicholasjng
Copy link
Contributor Author

Do you have an idea on how to inject C++17 as a standard into the Bazel 7.x job? I don't have it in my copts / cxxopts explicitly.

auto-merge was automatically disabled December 24, 2024 14:47

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed fmeum’s stale review December 24, 2024 14:47

Require module maintainers' approval for newly pushed changes.

Since we need to inject the correct cxxopt according to platform, we need
to unroll the platform and job definitions.
@fmeum fmeum merged commit 25eef4a into bazelbuild:main Dec 25, 2024
19 checks passed
@nicholasjng nicholasjng deleted the bump-nanobind-bazel branch December 27, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants