Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boost.units to modules #3492

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Add boost.units to modules #3492

merged 4 commits into from
Dec 26, 2024

Conversation

kgreenek
Copy link
Contributor

Closes #3489

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.units) have been updated in this PR. Please review the changes.

@kgreenek
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 25, 2024
Vertexwahn
Vertexwahn suggested changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@Vertexwahn Vertexwahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use version 1.83.0 instead of 1.83.0.bcr.1

@kgreenek kgreenek requested review from Vertexwahn and wep21 December 26, 2024 03:26
wep21
wep21 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green ci

@wep21
Copy link
Contributor

wep21 commented Dec 26, 2024

@fmeum @meteorcloudy request bazel maintainers review

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 26, 2024
@fmeum fmeum enabled auto-merge (squash) December 26, 2024 08:25
@wep21
Copy link
Contributor

wep21 commented Dec 26, 2024

@fmeum something seems to block merging. Could you merge this PR manually?

@fmeum fmeum merged commit 0d1e990 into bazelbuild:main Dec 26, 2024
30 checks passed
@kgreenek kgreenek deleted the kgk/boost-units branch December 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wep21 wep21 wep21 approved these changes

@fmeum fmeum fmeum approved these changes

@Vertexwahn Vertexwahn Awaiting requested review from Vertexwahn

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wanted: boost.units
5 participants
@kgreenek @bazel-io @wep21 @Vertexwahn @fmeum