Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate coverage tools to @remote_coverage_tools #10383

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public static LabelLateBoundDefault<TestConfiguration> coverageSupportAttribute(
"//tools/test:coverage_report_generator";

private static final String DEFAULT_COVERAGE_OUTPUT_GENERATOR_VALUE =
"@bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:Main";
"@bazel_tools//tools/test:lcov_merger";

@AutoCodec
static final Resolver<TestConfiguration, Label> COVERAGE_REPORT_GENERATOR_CONFIGURATION_RESOLVER =
Expand Down
1 change: 0 additions & 1 deletion tools/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ filegroup(
"//tools/python:embedded_tools",
"//tools/runfiles:embedded_tools",
"//tools/test:embedded_tools",
"//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:embedded_tools",
"//tools/osx/crosstool:srcs",
"//tools/osx:srcs",
"//tools/sh:embedded_tools",
Expand Down
9 changes: 7 additions & 2 deletions tools/test/BUILD.tools
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,14 @@ filegroup(
srcs = ["collect_coverage.sh"],
)

filegroup(
alias(
name = "coverage_report_generator",
srcs = ["@bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:Main"],
actual = "@remote_coverage_tools//:coverage_report_generator",
)

alias(
name = "lcov_merger",
actual = "@remote_coverage_tools//:lcov_merger",
)

filegroup(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,3 @@ filegroup(
srcs = glob(["**"]),
visibility = ["//visibility:public"],
)

filegroup(
name = "embedded_tools",
srcs = [
"BUILD.tools",
],
visibility = ["//visibility:public"],
)

This file was deleted.