Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0]Implement getDirectoryEntries and readdir for RemoteActionFileSystem. #16700

Closed
wants to merge 3 commits into from
Closed

Conversation

ShreeM01
Copy link
Contributor

@ShreeM01 ShreeM01 commented Nov 8, 2022

So spawns can read content of directires within action exuection.

Part of #16556.

PiperOrigin-RevId: 486918859
Change-Id: Ida86e4c927093d26f7f96d2f0c2aa0d1d74cc8a4

So spawns can read content of directires within action exuection.

Part of #16556.

PiperOrigin-RevId: 486918859
Change-Id: Ida86e4c927093d26f7f96d2f0c2aa0d1d74cc8a4
@ShreeM01 ShreeM01 requested a review from coeuvre November 8, 2022 19:26
ShreeM01 referenced this pull request Nov 8, 2022
So spawns can read content of directires within action exuection.

Part of #16556.

PiperOrigin-RevId: 486918859
Change-Id: Ida86e4c927093d26f7f96d2f0c2aa0d1d74cc8a4
@ShreeM01 ShreeM01 enabled auto-merge (squash) November 8, 2022 19:49
@coeuvre
Copy link
Member

coeuvre commented Nov 9, 2022

It seems that there are conflicts when doing the cherry-pick. Can you please cherry-pick 0a23d46 first?

@ShreeM01
Copy link
Contributor Author

ShreeM01 commented Nov 9, 2022

It seems that there are conflicts when doing the cherry-pick. Can you please cherry-pick 0a23d46 first?

Yeah sure! Here is the cherry-picked PR 16722. Thanks!

@coeuvre
Copy link
Member

coeuvre commented Nov 10, 2022

#16722 is merged, please rebase. Thanks!

@ShreeM01 ShreeM01 closed this Nov 10, 2022
auto-merge was automatically disabled November 10, 2022 21:27

Pull request was closed

@ShreeM01 ShreeM01 deleted the ks/cherry-pick16556 branch November 10, 2022 21:27
@ShreeM01
Copy link
Contributor Author

ShreeM01 commented Nov 10, 2022

Hi @coeuvre! Apologizing for accidentally closing this PR. Here is the link of new PR: #16738. Please review it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants