Make repo marker file parsing robust to version changes #23642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel 7.1.0 and 7.2.0 contains a bug where + characters in labels in the repository marker files cannot be parsed. This was fixed in commit d62e0a0. To reduce the rusk of future bugs in the same area, this change skips parsing the file if the first line shows that the content will not be used anyway, which should be reasonably safe if introducing new formats. Improves bazelbuild#23336 that fixed bazelbuild#23322.
github-actions
bot
added
the
awaiting-review
|
@Wyverald Feel free to abandon this PR if you think the current marker file parser is robust enough. I can't find any loop hole in the current parser, so I can't create any additional tests for this change. |
Wyverald
reviewed
Sep 17, 2024
src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java
Outdated
Show resolved
Hide resolved
iancha1992
added
the
team-ExternalDeps
moroten
commented
Sep 18, 2024
src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java
Outdated
Show resolved
Hide resolved
Wyverald
added
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 7.1.0 and 7.2.0 contains a bug where + characters in labels in the repository marker files cannot be parsed. This was fixed in commit d62e0a0. To reduce the rusk of future bugs in the same area, this change skips parsing the file if the first line shows that the content will not be used anyway, which should be reasonably safe if introducing new formats.
Improves #23336 that fixed #23322.