Allow decompression of nupkg #23645
Closed
Allow decompression of nupkg #23645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
|
Any chance this might still land in 7.4.0? @bazel-io fork 7.4.0 |
meteorcloudy
approved these changes
Sep 27, 2024
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 30, 2024
In some (legacy) projects, nuget is used to handle C++ packages. Nuget packages are working fine with WORKSPACE `http_archive` directives when explicitly specifying `type = "zip"`. However, when migrating to bzlmod, we ran into issues when the url in source.json is a nupkg file. This PR resolves that issue and allows consumption of nupkg archives as Bazel modules. Closes bazelbuild#23645. PiperOrigin-RevId: 680636414 Change-Id: Ia7fd3fc738a2dd68b1063dba0dc847c5b0668401
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
In some (legacy) projects, nuget is used to handle C++ packages. Nuget packages are working fine with WORKSPACE `http_archive` directives when explicitly specifying `type = "zip"`. However, when migrating to bzlmod, we ran into issues when the url in source.json is a nupkg file. This PR resolves that issue and allows consumption of nupkg archives as Bazel modules. Closes #23645. PiperOrigin-RevId: 680636414 Change-Id: Ia7fd3fc738a2dd68b1063dba0dc847c5b0668401 Commit b387036 Co-authored-by: Dennis van den Berg <[email protected]>
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some (legacy) projects, nuget is used to handle C++ packages.
Nuget packages are working fine with WORKSPACE
http_archivedirectives when explicitly specifyingtype = "zip".However, when migrating to bzlmod, we ran into issues when the url in source.json is a nupkg file.
This PR resolves that issue and allows consumption of nupkg archives as Bazel modules.