Fix upb build with Clang 16 #23667
Closed
Fix upb build with Clang 16 #23667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Xcode 16, `upb` fails its own `-Werror` check due to using Clang extensions.
|
FYI @keith |
github-actions
bot
added
the
awaiting-review
|
@bazel-io fork 7.4.0 |
meteorcloudy
added
awaiting-PR-merge
|
@iancha1992 Please import this one using the normal process. |
|
@meteorcloudy I don't know who to talk to about this, but ideally upb and protobuf would only enable warnings for their own project (e.g. via |
|
@pzembrod currently owns the C++ rules, but I don't think that's his current priority to make repo based c++ options work well. |
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 21, 2024
With Xcode 16, `upb` fails its own `-Werror` check due to using Clang extensions. Closes bazelbuild#23667. PiperOrigin-RevId: 676957876 Change-Id: I8e038b5f879077fefdb5811aff6ae5f56fb4f762
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 21, 2024
With Xcode 16, `upb` fails its own `-Werror` check due to using Clang extensions. Closes bazelbuild#23667. PiperOrigin-RevId: 676957876 Change-Id: I8e038b5f879077fefdb5811aff6ae5f56fb4f762
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 23, 2024
With Xcode 16, `upb` fails its own `-Werror` check due to using Clang extensions. Closes bazelbuild#23667. PiperOrigin-RevId: 676957876 Change-Id: I8e038b5f879077fefdb5811aff6ae5f56fb4f762
iancha1992
pushed a commit
that referenced
this pull request
Sep 24, 2024
With Xcode 16, `upb` fails its own `-Werror` check due to using Clang extensions. Closes #23667. PiperOrigin-RevId: 676957876 Change-Id: I8e038b5f879077fefdb5811aff6ae5f56fb4f762
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Xcode 16,
upbfails its own-Werrorcheck due to using Clang extensions.