Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let repo rules remove env vars for subprocesses #24221

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 6, 2024

RELNOTES: repository_ctx.execute can now remove an environment variable when executing a process by associating it with the value None in the environment argument.

RELNOTES: `repository_ctx.execute` can now remove an environment variable when executing a process by associating it with the value `None` in the `environment` argument.
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Nov 6, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 6, 2024
@meteorcloudy
Copy link
Member

@bazel-io fork 8.0.0

@copybara-service copybara-service bot closed this in 21a12c7 Nov 7, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 7, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Nov 7, 2024
RELNOTES: `repository_ctx.execute` can now remove an environment variable when executing a process by associating it with the value `None` in the `environment` argument.

Closes bazelbuild#24221.

PiperOrigin-RevId: 694048622
Change-Id: Ia779e9133411745c9cfe93845c13839d05731c7c
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2024
RELNOTES: `repository_ctx.execute` can now remove an environment
variable when executing a process by associating it with the value
`None` in the `environment` argument.

Closes #24221.

PiperOrigin-RevId: 694048622
Change-Id: Ia779e9133411745c9cfe93845c13839d05731c7c

Commit
21a12c7

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants