Support rule based cc_toolchains with dwp actions #25071
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwp actions are built up solely from tool_paths. Rule based toolchains have no tool paths, resulting in an error when trying to find the dwp executable. Unfortunately, we can't just switch to cc_common.get_tool_for_action because the old toolchains only have the path for dwp in tool_paths. So, try the old API first, and if it fails, try the new one. Signed-off-by: Austin Schuh <[email protected]>
github-actions
bot
added
the
awaiting-review
|
FYI, @fmeum |
fmeum
approved these changes
Jan 25, 2025
Co-authored-by: Fabian Meumertzheim <[email protected]>
|
Looking around for similar patterns, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dwp actions are built up solely from tool_paths. Rule based toolchains have no tool paths, resulting in an error when trying to find the dwp executable.
Unfortunately, we can't just switch to cc_common.get_tool_for_action because the old toolchains only have the path for dwp in tool_paths. So, try the old API first, and if it fails, try the new one.