Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop --exec_constraints from rbe-configs/generate.py #1725

Closed
wants to merge 1 commit into from

Conversation

hvadehra
Copy link
Member

rbe_configs_gen does not and AFAICT never did expose such a flag.

In fact, the flag had a typo from when it was introduced till cfad46d several months later which makes me think this script was either never used, or if it was, it was used with a custom build of rbe_configs_gen that does expose that flag.

@coeuvre
Copy link
Member

coeuvre commented Aug 22, 2023

I used a custom build of rbe_configs_gen. The PR for adding the flag is bazelbuild/bazel-toolchains#968 but I never managed to make it merged. Maybe I should.

@hvadehra
Copy link
Member Author

I used a custom build of rbe_configs_gen. The PR for adding the flag is bazelbuild/bazel-toolchains#968 but I never managed to make it merged. Maybe I should.

AFAICT, the exec_constraints are the same as the defaults in rbe_configs_gen. Only diff is @bazel_tools//tools/cpp:gcc vs @bazel_tools//tools/cpp:clang which are anyways identical.

@coeuvre
Copy link
Member

coeuvre commented Aug 24, 2023

Did we change how C++ toolchain auto-detection works in Bazel?

More specifically, the requirement was we want this configuration to use gcc instead clang in the docker image.

@hvadehra
Copy link
Member Author

My bad, please ignore what I said, I misread the BUILD.tools file.

@hvadehra hvadehra closed this Oct 4, 2023
@hvadehra hvadehra deleted the exec_constraints branch October 4, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants