[AOSP-pick] Do not wait for the write lock #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `BuildArtifactCacheDirectory` as it may cause a deadlock if the wait queue looks like "W", "R".. when the read lock is already held. The first read lock stamp is released only after all reads are processed and they won't until the write is processed but it can't proceed. Bug: 373957467 Test: n/a Change-Id: Ice28bae0288296fa8ed17c31187b578affb8d46c AOSP: cff9f98e002cc7f7d7d379090f9dd4655221a278
github-actions
bot
added
the
awaiting-review
sellophane
approved these changes
Jan 7, 2025
|
Blocked by failing Mac CI, probably caused by us not using the JBR :( |
|
@LeFrosch passing after retry |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit cff9f98e002cc7f7d7d379090f9dd4655221a278.
in
BuildArtifactCacheDirectoryas it may cause a deadlock if thewait queue looks like "W", "R".. when the read lock is already held.
The first read lock stamp is released only after all reads are processed
and they won't until the write is processed but it can't proceed.
Bug: 373957467
Test: n/a
Change-Id: Ice28bae0288296fa8ed17c31187b578affb8d46c
AOSP: cff9f98e002cc7f7d7d379090f9dd4655221a278