Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac agent native errors #7216

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Fix mac agent native errors #7216

merged 3 commits into from
Jan 10, 2025

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Jan 10, 2025

Recently I started to notice some native errors on our Mac CI agents. This is probably because we are running the tests with java 17. Ideally we would use the right JBR version for the selected ij_product, but this would require a more significant change. Bumping java to 21 is a temporary workaround.

@LeFrosch LeFrosch marked this pull request as ready for review January 10, 2025 12:50
@github-actions github-actions bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels Jan 10, 2025
@LeFrosch LeFrosch requested a review from ujohnny January 10, 2025 12:51
Copy link
Collaborator

@ujohnny ujohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should be enough to run on 21 and migration of JDK to 21 is not mandatory to address the issue. Otherwise LGTM

@LeFrosch LeFrosch merged commit 28f8725 into bazelbuild:master Jan 10, 2025
7 checks passed
@LeFrosch LeFrosch deleted the java-21 branch January 10, 2025 14:57
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin
Projects
Development

Successfully merging this pull request may close these issues.

2 participants