Add objc_compile to compile_actions #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of the time objc_compile is identical to C/C++ compiles. Because of this I think by default all of those flags should apply here. This is a bit funny since the current builtin toolchain doesn't support Objective-C at all and that's only in the apple_support toolchain, but new toolchains using these rules may want to support this. Without this things like `--objccopt` just don't work out of the box.
keith
force-pushed
the
ks/add-objc_compile-to-compile_actions
branch
from
2614ae4
to
97cc237
Compare
comius
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the time objc_compile is identical to C/C++ compiles. Because of this I think by default all of those flags should apply here. This is a bit funny since the current builtin toolchain doesn't support Objective-C at all and that's only in the apple_support toolchain, but new toolchains using these rules may want to support this.
Without this things like
--objccoptjust don't work out of the box.