Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Update Bazel, rules_go and bazel-gazelle versions. #2222

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blorente
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, the puller binary fails to build in my arm macOS machine (fails to find a go toolchain, amongst other issues). Upgrading the Bazel, rules_go and bazel-gazelle versions fixes the issue.

What is the new behavior?

Does this PR introduce a breaking change?

Quite possibly, though it broke none of our tests.

It's possible that the upgrade to rulesets introduces unwanted versions of go dependencies into the build. The mitigation strategy, for now, is unfortunately to fiddle with the order of imports in the user's WORKSPACE files in order to ensure that their version of the go dependency gets picked.

@golovasteek
Copy link

I ran into the issue that rules-proto-grpc use version 0.37 of rules_go and it is incompatible with the version 0.24 used in rule docker.

Would be great if rules_docker would bump the version as well.

@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants