This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Update Bazel, rules_go and bazel-gazelle versions. #2222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the puller binary fails to build in my arm macOS machine (fails to find a go toolchain, amongst other issues). Upgrading the Bazel, rules_go and bazel-gazelle versions fixes the issue.
What is the new behavior?
Does this PR introduce a breaking change?
Quite possibly, though it broke none of our tests.
It's possible that the upgrade to rulesets introduces unwanted versions of go dependencies into the build. The mitigation strategy, for now, is unfortunately to fiddle with the order of imports in the user's
WORKSPACE
files in order to ensure that their version of the go dependency gets picked.