Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Expand location templates in container_run_and_extract rule. #2235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

k0walik
Copy link

@k0walik k0walik commented Mar 20, 2023

The container_run_and_extract rule accepts list of labels as the input arguments passed to the action running the container. We could elevate this information by applying expand_templates to docker_run_flags and pass generated files (i.e. environmental variables) as the input to the shell script that executes the action.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Location templates in docker_run_flags are passed to docker run commands as literal strings.

Issue Number: N/A

What is the new behavior?

Expand location templates before expanding shell script templates, so the paths to generated files are passed correctly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant