Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Support push_targets in container_bundle #2253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codersasha
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

container_bundle only supports a strange dictionary format for images.

What is the new behavior?

container_bundle can take a push_targets parameter, and the info for the image (repository, tag, etc) is taken from existing push rules. This also means contains_bundle supports using tag_files, and the subsequent push-all rule can push using these tag files as well.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant