Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Add toolchain param to the affected actions #2271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kotlaja
Copy link

@kotlaja kotlaja commented Aug 31, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • [ x] Other... Please describe: This is a step forward for the migration of Automatic Exec Groups. Each action which uses tool/executable should add a toolchain param.

What is the current behavior?

Exec platform selection is on a rule level. Which means that a rule can have one default execution platform, unless specified differently via exec_groups.

Issue Number: N/A

What is the new behavior?

Exec platform selection is on a toolchain_type level. Which means that each action on a rule can have a different execution platform.

Does this PR introduce a breaking change?

  • Yes
  • [ x ] No - Not for now since AEGs are still disabled in Bazel. Once they becom enabled, you will have more information connected to possible errors (issue description on github and incompatible flag).

Other information

@kotlaja
Copy link
Author

kotlaja commented Aug 31, 2023

Oh, I see that you're using Bazel 4.0. Is there a possibility to update it to Bazel 6.0? toolchain param is available from 6.0. onwards.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant