Fix comments

bazelbuild · Oct 9, 2023 · 87be14c · 87be14c
1 parent 51d7052
commit 87be14c
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 15 deletions.
diff --git a/proto/protobuf/proto.bzl b/proto/protobuf/proto.bzl
@@ -20,7 +20,6 @@ load(
     _generate_proto = "rust_generate_proto",
     _generated_file_stem = "generated_file_stem",
 )
-load("//rust:defs.bzl", "rust_common")
 
 # buildifier: disable=bzl-visibility
 load("//rust/private:rustc.bzl", "rustc_compile_action")

diff --git a/rust/private/rustc.bzl b/rust/private/rustc.bzl
@@ -1095,13 +1095,11 @@ def rustc_compile_action(
         ctx (ctx): The rule's context object
         attr (struct): Attributes to use for the rust compile action
         toolchain (rust_toolchain): The current `rust_toolchain`
-        crate_type: TODO
-        crate_info (CrateInfo): The CrateInfo provider for the current target.
         output_hash (str, optional): The hashed path of the crate root. Defaults to None.
         rust_flags (list, optional): Additional flags to pass to rustc. Defaults to [].
         force_all_deps_direct (bool, optional): Whether to pass the transitive rlibs with --extern
             to the commandline as opposed to -L.
-        create_crate_info_callback: A callback to construct a mutable dict for constructor CrateInfo
+        crate_info_dict: A mutable dict used to create CrateInfo provider
         skip_expanding_rustc_env (bool, optional): Whether to expand CrateInfo.rustc_env
 
     Returns:
@@ -1110,9 +1108,6 @@ def rustc_compile_action(
             - (DepInfo): The transitive dependencies of this crate.
             - (DefaultInfo): The output file for this crate, and its runfiles.
     """
-
-    # TODO: Remove create_crate_info_callback after all rustc_compile_action callers migrate to
-    # removing CrateInfo construction before `rust_compile_action
     crate_info = rust_common.create_crate_info(**crate_info_dict)
 
     build_metadata = None

diff --git a/test/unit/consistent_crate_name/with_modified_crate_name.bzl b/test/unit/consistent_crate_name/with_modified_crate_name.bzl
@@ -1,7 +1,5 @@
 """A custom rule that threats all its dependencies as direct dependencies."""
 
-load("//rust:defs.bzl", "rust_common")
-
 # buildifier: disable=bzl-visibility
 load("//rust/private:providers.bzl", "BuildInfo", "CrateInfo", "DepInfo", "DepVariantInfo")
 

diff --git a/test/unit/force_all_deps_direct/generator.bzl b/test/unit/force_all_deps_direct/generator.bzl
@@ -1,8 +1,5 @@
 """A custom rule that threats all its dependencies as direct dependencies."""
 
-# buildifier: disable=bzl-visibility
-load("//rust/private:common.bzl", "rust_common")
-
 # buildifier: disable=bzl-visibility
 load("//rust/private:providers.bzl", "BuildInfo", "CrateInfo", "DepInfo", "DepVariantInfo")
 

diff --git a/test/unit/pipelined_compilation/wrap.bzl b/test/unit/pipelined_compilation/wrap.bzl
@@ -1,8 +1,5 @@
 """A custom rule that wraps a crate called to_wrap."""
 
-# buildifier: disable=bzl-visibility
-load("//rust/private:common.bzl", "rust_common")
-
 # buildifier: disable=bzl-visibility
 load("//rust/private:providers.bzl", "BuildInfo", "CrateInfo", "DepInfo", "DepVariantInfo")