Skip to content

Commit

Permalink
Disable frequently failing Windows CI (#2187)
Browse files Browse the repository at this point in the history
Also, update the docs to reflect that realistically we can't support
Windows well without a relevant maintainer.

This is a very large hammer, but realistically these tests have wasted a
lot of our time and no one is well positioned to address them.

Fixes #1946 
Relates to #2186
  • Loading branch information
illicitonion authored Oct 9, 2023
1 parent 699c833 commit a7eba05
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 22 deletions.
41 changes: 21 additions & 20 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -485,26 +485,27 @@ tasks:
test_targets:
- "//..."
build_flags: *aspects_flags
crate_universe_examples_windows:
name: Crate Universe Examples
platform: windows
working_directory: examples/crate_universe
run_targets: *crate_universe_vendor_example_targets
build_flags: *aspects_flags
build_targets:
- "//..."
test_targets:
- "//..."
crate_universe_unnamed_examples_windows:
name: Crate Universe Unnamed Examples
platform: windows
working_directory: examples/crate_universe_unnamed
run_targets: *crate_universe_unnamed_vendor_example_targets
build_flags: *aspects_flags
build_targets:
- "//..."
test_targets:
- "//..."
# See https://github.com/bazelbuild/rules_rust/issues/2186 about re-enabling these.
# crate_universe_examples_windows:
# name: Crate Universe Examples
# platform: windows
# working_directory: examples/crate_universe
# run_targets: *crate_universe_vendor_example_targets
# build_flags: *aspects_flags
# build_targets:
# - "//..."
# test_targets:
# - "//..."
# crate_universe_unnamed_examples_windows:
# name: Crate Universe Unnamed Examples
# platform: windows
# working_directory: examples/crate_universe_unnamed
# run_targets: *crate_universe_unnamed_vendor_example_targets
# build_flags: *aspects_flags
# build_targets:
# - "//..."
# test_targets:
# - "//..."
cc_common_link_ubuntu2004:
name: Build via cc_common.link
platform: ubuntu2004
Expand Down
4 changes: 2 additions & 2 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ We test these rules against the latest rolling releases of Bazel, and aim for co

## Supported platforms

We aim to support Linux, macOS, and Windows.
We aim to support Linux and macOS.

Windows support is less complete than the other two platforms, but most things work, and we welcome contributions to help improve its support.
We do not have sufficient maintainer expertise to support Windows. Most things probably work, but we have had to disable many tests in CI because we lack the expertise to fix them. We welcome contributions to help improve its support.

Windows support for some features requires `--enable_runfiles` to be passed to Bazel, we recommend putting it in your bazelrc. See [Using Bazel on Windows](https://bazel.build/configure/windows) for more Windows-specific recommendations.

0 comments on commit a7eba05

Please sign in to comment.