Add toolchain parameter to the affected actions
#2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scentini
reviewed
Sep 4, 2023
|
@scentini Can you please take a look once again? :) |
scentini
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the migration of Automatic Exec Groups (AEGs design doc).
In this PR I've added a
toolchainparam to the affected actions (actions for which we can't detect if their tools/executable are coming from a toolchain). That's why sometimes it's set to None. Thetoolchainparam is visible from Bazel 6.0, which rules_rust already supports.Important note to reviewers: Please check if the correct toolchain type is added for each action. I’ve done my best, but additional precaution is not harmful. 🙂
Also note that this toolchain param is not used right now since AEGs are still not enabled (there should be no errors). This is mostly step forward for the internal changes, and I will focus on enabling AEGs in Bazel after it's fully tested inside Google.