Add hdrs and includes attributes to rust_static_library #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daivinhtran
force-pushed
the
add-hdrs-and-includes-attrs
branch
5 times, most recently
from
9dec5f3 to
6cc8c47
Compare
daivinhtran
force-pushed
the
add-hdrs-and-includes-attrs
branch
from
6cc8c47 to
184a9b4
Compare
daivinhtran
force-pushed
the
add-hdrs-and-includes-attrs
branch
from
1eb8d91 to
f7cc416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
hdrsandincludessimilar to cc_library rule to allow cc rdeps to include the rust static library interface (headers) in the source such asThe header file needs to use
extern "C"to tell the C++ compiler that the function it is expecting won't be name-mangled. See the example for a working example.