Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _rustc_env_attr from CrateInfo #2189

Merged
merged 18 commits into from
Oct 18, 2023
Merged

Remove _rustc_env_attr from CrateInfo #2189

merged 18 commits into from
Oct 18, 2023

Conversation

daivinhtran
Copy link
Contributor

@daivinhtran daivinhtran commented Oct 9, 2023 •
edited
Loading

#2188's follow-up PR to remove unused _rustc_env_attr field in CrateInfo provider. We can rely on skip_expanding_rustc_env to determine whether rustc_env is already expanded or not.

@daivinhtran daivinhtran force-pushed the remove-rustc_env_attr branch from 49c3887 to 348e9e7 Compare October 9, 2023 21:35
@daivinhtran daivinhtran force-pushed the remove-rustc_env_attr branch from bb6dd4b to 0e899d7 Compare October 9, 2023 22:16
@daivinhtran daivinhtran changed the title Remove rustc env attr Remove _rustc_env_attr from CrateInfo Oct 9, 2023
@daivinhtran daivinhtran marked this pull request as ready for review October 17, 2023 19:02
scentini
scentini approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@scentini scentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scentini scentini merged commit 80c8dd5 into bazelbuild:main Oct 18, 2023
2 checks passed
@daivinhtran daivinhtran deleted the remove-rustc_env_attr branch January 10, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scentini scentini scentini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daivinhtran @scentini