Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass JVM arguments #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions jaydebeapi/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def _handle_sql_exception_jython():
exc_type = InterfaceError
reraise(exc_type, exc_info[1], exc_info[2])

def _jdbc_connect_jython(jclassname, url, driver_args, jars, libs):
def _jdbc_connect_jython(jclassname, url, driver_args, jars, libs, jvm_args):
if _jdbc_name_to_const is None:
from java.sql import Types
types = Types
Expand Down Expand Up @@ -164,10 +164,10 @@ def _handle_sql_exception_jpype():

reraise(exc_type, exc_info[1], exc_info[2])

def _jdbc_connect_jpype(jclassname, url, driver_args, jars, libs):
def _jdbc_connect_jpype(jclassname, url, driver_args, jars, libs, jvm_args):
import jpype
if not jpype.isJVMStarted():
args = []
args = jvm_args or []
class_path = []
if jars:
class_path.extend(jars)
Expand Down Expand Up @@ -378,7 +378,7 @@ def TimestampFromTicks(ticks):
return apply(Timestamp, time.localtime(ticks)[:6])

# DB-API 2.0 Module Interface connect constructor
def connect(jclassname, url, driver_args=None, jars=None, libs=None):
def connect(jclassname, url, driver_args=None, jars=None, libs=None, jvm_args=None):
"""Open a connection to a database using a JDBC driver and return
a Connection instance.

Expand All @@ -394,6 +394,7 @@ def connect(jclassname, url, driver_args=None, jars=None, libs=None):
jars: Jar filename or sequence of filenames for the JDBC driver
libs: Dll/so filenames or sequence of dlls/sos used as shared
library by the JDBC driver
jvm_args: additional JVM arguments to be passed
"""
if isinstance(driver_args, string_type):
driver_args = [ driver_args ]
Expand All @@ -409,7 +410,7 @@ def connect(jclassname, url, driver_args=None, jars=None, libs=None):
libs = [ libs ]
else:
libs = []
jconn = _jdbc_connect(jclassname, url, driver_args, jars, libs)
jconn = _jdbc_connect(jclassname, url, driver_args, jars, libs, jvm_args)
return Connection(jconn, _converters)

# DB-API 2.0 Connection Object
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
setup(
#basic package data
name = 'JayDeBeApi',
version = '1.2.3',
version = '1.2.4',
author = 'Bastian Bowe',
author_email = '[email protected]',
license = 'GNU LGPL',
Expand Down