Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ovirt and openstack #389

Open
wants to merge 25 commits into
base: development
Choose a base branch
from

Conversation

ekrichbaum
Copy link

No description provided.

@gstorme
Copy link

gstorme commented Jun 17, 2024

I've tested the ovirt sync (thank you!).
It seems that VMs in the down state are not synced to netbox.
When running with DEBUG2 loglevel, I notice these:

2024-06-17 16:59:03,311 - DEBUG: Parsing oVirt VM: okd-net001
2024-06-17 16:59:03,311 - DEBUG2: Ignoring offline VM 'okd-net001' on first run

But this also occurs on every subsequent run.

@gstorme
Copy link

gstorme commented Jun 17, 2024

mac_address should be normalized, you do this for virtual machines but not for a host.
This causes a changelog entry for every host interface mac address.

@gstorme
Copy link

gstorme commented Jun 18, 2024

I've pushed some changes in a PR to fix the comments above.

@bb-Ricardo
Copy link
Owner

Sorry this is still in my backlog for review

@bb-Ricardo
Copy link
Owner

Just wondering about all the config options in config.py are all of these used and supported? I would also assume there no deprecated ones.

Can you please have a look at them?

@ekrichbaum
Copy link
Author

There are a few caveats that maybe need a specific readme doc to note?

  • Memory is not included in the openstack vmobject itself. That needs another call to another location probably.
  • Flavor should probably be pulled and added as a tag potentially.
  • Came across a use case in multi openstack testing where the url given is used to login and then the targets get returned and used from there. If the target doesn't match, we get an auth failure. i.e. use an ip in auth_url but the targets returned the name. As long as the hosts file or dns contains the name to the ip, this does function otherwise crashes out completely. Needs an error trap and potentially an option and function to rewrite the host portion of those URLs.

@n-rodriguez n-rodriguez mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants