feat: adding a flag to force consumer to always acknowledge #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #443
Description:
As described in the issue, when we added acknowledgement some time ago, we did so in a way that broke the expected behaviour from users by changing the internal expectation of how the handlers should return and what happens as a result of that return.
Type of change:
Why is this change required?:
While we can't undo this breaking change, and we can't reverse this new default behaviour (as that would be another breaking change), this change goes some way to resolve the issue by adding a feature flag that allows users to change this default behaviour, forcing the consumer to always acknowledge all messages, no matter the returned data from the handlers.
Code changes:
alwaysAcknowledge