Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating attributeNames type docs #452

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

nicholasgriffintn
Copy link
Member

Resolves #451

Description:

Previously, we listed a number of example values for the attributeNames name option, which did not entirely line up with the types that AWS was actually providing through QueueAttributeName.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

To ensure that users aren't confused by the type provided by SQS Consumer.

Code changes:

Copy link

codeclimate bot commented Jan 21, 2024

Code Climate has analyzed commit 644d5fc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.

@nicholasgriffintn nicholasgriffintn merged commit 84385d2 into main Jan 21, 2024
8 of 9 checks passed
@nicholasgriffintn nicholasgriffintn deleted the update-queueattributename-docs branch January 21, 2024 02:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ApproximateReceiveCount is not part of QueueAttributeName
1 participant