[CLOSED] Add path parameter to customized plugins #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new key in in `AnnotationKey`class for path - edit yaml config - edit plugin search glob given the path.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #22 +/- ##
===========================================
- Coverage 85.01% 84.97% -0.05%
===========================================
Files 44 44
Lines 1902 1903 +1
===========================================
Hits 1617 1617
- Misses 285 286 +1 ☔ View full report in Codecov by Sentry. |
FedericaBrando
deleted the
21-openvariant--add-path-to-external-plugin-folder-in-annotation
branch
|
Closed as we decided to go with another solution. Ref |
FedericaBrando
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of implementation of new key for plugins in the annotation. ref to
summary:
AnnotationKeyclass for path#TODOs:
@dmartmillan @CarlosLopezElorduy
This implementation includes the possibility of adding a parameter "path" to where to find the customized plugins.
Although I think this solves only part of the problem, since it would accept the path, although we need to understand a way to handle plugins in packages that uses openvariant (i.e. cgi-pipeline)