Add environment variable OPENVAR_PLUGIN
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set `OPENVAR_PLUGIN`to `$HOME/.local/share/openvariant` - check if environment variable are not in the env otherwise adds them - check if path extists already, otherwise create directory - update requiremente with appdir package
- update plugin builder to look for external plugin in `OPENVAR_PLUGIN` - update create plugin function to use env_var by default - Add `loadEnvironmentVariables()` so plugin tests do not fail.
|
tested implementation with cgi-pipeline with success. |
CarlosLopezElorduy
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the use of an environment variable in Openvariant that stores where the plugin should be search and create.
by default the path is:
Given issue
Please feel free to add any comment, suggestion, improvement that can be added to finalize this PR.