-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bbkane/parse2 #81
Merged
Merged
Bbkane/parse2 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to debug tests tomorrow
I was forgetting to return early on success, so values were being updated by the config, then overwritten by the default
Only thing left is fixing the example test
Examples: ``` $ go run ./examples/butler --color false -h Parse err: Parse args error: expecting section or command, got --color exit status 64 ``` ```bash $ WARG_PRE_V0_0_26_PARSE_ALGORITHM=1 go run ./examples/butler --color false -h A virtual assistant ... more ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.0.26
Changed
SetBy
into theValue
interface (value.UpdatedBy()
- this allowsFlag
to be readonly and and makes the coupling between setting the value andupdating
UpdatedBy
explicit<appname> <section> <command> <flag>...
. In addition, the only flag allowed after a<section>
isthe
--help
flag (unfortunately the--color
flag is NOT currently allowed tobe passed for section help). This simplifies the parsing and will help with tab
completion, and after that's implemented I might try to restore the old
behavior if I get too annoyed with this limitation. Temporarily, the old
behavior can be restored by setting the
WARG_PRE_V0_0_26_PARSE_ALGORITHM
environment variable, but I plan to remove that in the next version.
Examples: