create index as part of the test #1084
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13829826 | Triggered | Username Password | 9497571 | backend/search/query_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
backend/search/query_test.go
Outdated
| } | ||
|
|
||
| client.Indices.Create(testIndexName).Do(ctx) | ||
| client.Indices.PutMapping(testIndexName).Request(&putmapping.Request{Properties: map[string]types.Property{ |
There was a problem hiding this comment.
what does the index look like? Can you point me to the definition of the index?
There was a problem hiding this comment.
The idea is to get something similar to what we have in BMM: https://github.com/bcc-code/bmm-api/blob/develop/BMM.Api.Infrastructure.Tests/ElasticSearch/SearchTrackTests.cs
- create an index for the test
- fill it with the test data that is needed for this test
- run actual test
- delete everything
There was a problem hiding this comment.
| if query.Type != nil { | ||
| indexName = typeToIndexMap[*query.Type] | ||
| } | ||
| if indexNameParameter != "" { | ||
| indexName = indexNameParameter | ||
| } |
There was a problem hiding this comment.
The index is set based on what you are queriying. You should not be able to query for episodes and spec to search the season index.
If that is needed for testing then initialization of the client should accept index config.
No description provided.