Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing auto selection of certificate type. In exchange, error message pops up right away on new application + other bug fixes #169

Merged
merged 11 commits into from
Apr 2, 2024

Conversation

SoLetsDev
Copy link
Contributor

@SoLetsDev SoLetsDev commented Mar 26, 2024

ECER-1013: Brief description of the changes

  • Certificate form doesn't auto select a certification (ECER-1013)
  • Bug fix where applicant could click back and forward to avoid form validation (ECER-812). Added a v-if on forms to ensure they get remounted each time we travel through the stepper.
  • Updated wording for education checkbox (ECER-716)
  • Alert box for duplicated character reference in work experience reference. ECER-1040
  • Bug fix forms would fire off validation when switching between stepper. Showing error messages right away when we first arrive to the forms. (Had to do some setTimeout resetvalidation to prevent this jankiness.
  • Bug fix character reference doesn't get cleared out when user removes first name, last name and email.

Checklist

  • I have tested these changes locally.
  • Changes to backend endpoints are covered by passing integration tests.
  • I have added or updated the necessary documentation.

Screenshots
Alert Box and Error on preview page for work experience reference
image

image

@SoLetsDev SoLetsDev marked this pull request as draft March 27, 2024 18:50
@SoLetsDev SoLetsDev changed the title removing auto selection of certificate type. In exchange, error message pops up right away on new application removing auto selection of certificate type. In exchange, error message pops up right away on new application + other bug fixes Mar 27, 2024
@SoLetsDev SoLetsDev marked this pull request as ready for review March 27, 2024 19:03
Copy link
Contributor

@pcatkins pcatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@SoLetsDev SoLetsDev requested a review from pcatkins March 28, 2024 22:28
@SoLetsDev SoLetsDev merged commit 5bb8f21 into master Apr 2, 2024
5 checks passed
@SoLetsDev SoLetsDev deleted the stories/ecer-1013 branch April 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants