Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECER-1053: Preview Page Error Handling #170

Merged
merged 5 commits into from
Mar 27, 2024
Merged

ECER-1053: Preview Page Error Handling #170

merged 5 commits into from
Mar 27, 2024

Conversation

pcatkins
Copy link
Contributor

Description

  • Modified PreviewCard component to reflex validation state
  • Adjusted preview section components that use PreviewCard
  • Fixed broken work experience references validation
  • Fixed broken dummy data generator function for Character Reference

Related Jira Issue(s)

Checklist

  • I have tested these changes locally.
  • Changes to backend endpoints are covered by passing integration tests.
  • I have added or updated the necessary documentation.

Screenshots (if applicable)

Screenshot 2024-03-26 at 10 50 29 PM

Additional Comments (optional)

Any additional context or information that might be helpful for the reviewer.

@pcatkins pcatkins merged commit a8ce646 into master Mar 27, 2024
5 checks passed
@pcatkins pcatkins deleted the stories/ECER-1053 branch March 27, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoLetsDev SoLetsDev SoLetsDev approved these changes

@farzadnadiri farzadnadiri Awaiting requested review from farzadnadiri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcatkins @SoLetsDev