FE New User Flow #36
Merged
FE New User Flow #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pcatkins
commented
Jan 17, 2024
pcatkins
commented
- New unit test for partial user create success
- Route protection for /new-user routes
- Get user and create user API calls
- Check for existing user, show dashboard or new-user page accordingly
pcatkins
commented
Jan 17, 2024
src/ECER.Clients.RegistryPortal/ECER.Clients.RegistryPortal.Server/Users/UserInfoEndpoints.cs
Show resolved
Hide resolved
ytqsl
requested changes
Jan 17, 2024
|
|
||
| // Check if the response has data and userInfo property | ||
| return response?.data?.userInfo ?? null; | ||
| } catch (error) { |
There was a problem hiding this comment.
should it be more specific catch on 404?
There was a problem hiding this comment.
Yes can do. It doesn't change much as far as handling the error at this point. We still need to identify how we want to handle errors FE moving forward (alert/toast user, log?, etc.).
Adjusted to add catch 404
There was a problem hiding this comment.
not exactly - 404 here has a true meaning: that user was not found, hence it is a new user
...Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/pages/Dashboard.vue
Outdated
Show resolved
Hide resolved
ytqsl
approved these changes
Jan 18, 2024
ytqsl
approved these changes
Jan 18, 2024
ytqsl
approved these changes
Jan 18, 2024
ytqsl
approved these changes
Jan 18, 2024
ytqsl
approved these changes
Jan 18, 2024
ytqsl
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.