ECER-485: Authentication SSO (BCeID) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pcatkins
commented
Dec 5, 2023
pcatkins
commented
- Login protection for authenticated users
- Route protection for non-authenticated users
- Login with BCeID button starts SSO login sequence
- Subsequent API calls contain access token in authorization header
- OpenID configuration fetched from server before app mount
- Added default Jetbrains .gitignore - Initial config files
- Vue router - Pinia store - Moved api calls out of component - Removed starter main.css
- Move service calls into Pinia store - Simplify component code
…o parker/authentication
- Navigation guard for authentication protected routes - Navigation guard for login if already authenticated - Persist authentication state with pinia-plugin-persistedstate
ytqsl
requested changes
Dec 6, 2023
src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/api/application.ts
Outdated
Show resolved
Hide resolved
src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/yarn.lock
Outdated
Show resolved
Hide resolved
- Increased prettier line length to 120 chars + lint - Remove yarn.lock to use NPM - Added .idea/ to .gitignore and removed JetBrains boilerplate - Remove .idea/ folder
|
@ytqsl PR updated with requested changes, please re-review. |
ytqsl
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.