Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPICSYSTEM-225: Create staff modal form #12

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

nitheesh-aot
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 16.85393% with 74 lines in your changes missing coverage. Please review.

Project coverage is 37.52%. Comparing base (a3081ae) to head (766561f).

Files Patch % Lines
...liance-web/src/components/App/Staff/StaffModal.tsx 5.88% 32 Missing ⚠️
compliance-web/src/hooks/useStaff.tsx 40.74% 16 Missing ⚠️
...pliance-web/src/components/App/Staff/StaffForm.tsx 8.33% 11 Missing ⚠️
compliance-web/src/utils/axiosUtils.ts 0.00% 9 Missing ⚠️
...ance-web/src/routes/_authenticated/admin/staff.tsx 0.00% 5 Missing ⚠️
.../components/Shared/Modals/ModalCloseIconButton.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #12      +/-   ##
===========================================
- Coverage    42.81%   37.52%   -5.29%     
===========================================
  Files           38       44       +6     
  Lines          334      429      +95     
  Branches        61       79      +18     
===========================================
+ Hits           143      161      +18     
- Misses         178      254      +76     
- Partials        13       14       +1     
Flag Coverage Δ
compliance-web 37.52% <16.85%> (-5.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// eslint-disable-next-line no-console
console.log(formData);
// if (user) {
// updateUser({ ...user, ...formData });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these if not important

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just kept from the scaffold one, need to implement the add and update in that area.
I will remove that once it's implemented. It's already in my TODO list.

name: string;
}

const mockUsersList: MockUser[] = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the mock for the dropdown list. You should call the Epic.Auth endpoint directly.
{ "id": "5bca57e4-1b39-498c-8872-732d3da4beaf", "first_name": "Shaelyn", "last_name": "Tolk", "email_address": "[email protected]", "username": "0790439a8c0448ed94ebe98d759bce6a@idir" },
You have to show the {first_name} {last_name} format and get the username as the selected value

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, This for the name and other users dropdown list. I will connect to epic.auth for this.

@nitheesh-aot nitheesh-aot merged commit 8da7a28 into bcgov:develop Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants