-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPICSYSTEM-225: Create staff modal form #12
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12 +/- ##
===========================================
- Coverage 42.81% 37.52% -5.29%
===========================================
Files 38 44 +6
Lines 334 429 +95
Branches 61 79 +18
===========================================
+ Hits 143 161 +18
- Misses 178 254 +76
- Partials 13 14 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
// eslint-disable-next-line no-console | ||
console.log(formData); | ||
// if (user) { | ||
// updateUser({ ...user, ...formData }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these if not important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just kept from the scaffold one, need to implement the add and update in that area.
I will remove that once it's implemented. It's already in my TODO list.
name: string; | ||
} | ||
|
||
const mockUsersList: MockUser[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the mock for the dropdown list. You should call the Epic.Auth endpoint directly.
{ "id": "5bca57e4-1b39-498c-8872-732d3da4beaf", "first_name": "Shaelyn", "last_name": "Tolk", "email_address": "[email protected]", "username": "0790439a8c0448ed94ebe98d759bce6a@idir" },
You have to show the {first_name} {last_name} format and get the username as the selected value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, This for the name and other users dropdown list. I will connect to epic.auth for this.
No description provided.