Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /staff-users #8

Merged
merged 2 commits into from
Aug 8, 2024
Merged

GET /staff-users #8

merged 2 commits into from
Aug 8, 2024

Conversation

dinesh-aot
Copy link
Collaborator

@dinesh-aot dinesh-aot commented Aug 7, 2024

  1. /staff-users GET endpoint added
  2. positions GET endpoint added
  3. /staff-users/permissions GET endpoint added

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.81369% with 203 lines in your changes missing coverage. Please review.

Project coverage is 36.00%. Comparing base (252a5b3) to head (94498d1).

Files Patch % Lines
...ance-api/src/compliance_api/services/staff_user.py 0.00% 44 Missing ⚠️
...nce-api/src/compliance_api/resources/staff_user.py 0.00% 29 Missing ⚠️
...iance-api/src/compliance_api/schemas/staff_user.py 0.00% 29 Missing ⚠️
...iance-api/src/compliance_api/resources/position.py 0.00% 20 Missing ⚠️
compliance-api/src/compliance_api/models/db.py 26.92% 19 Missing ⚠️
...liance-api/src/compliance_api/models/staff_user.py 63.41% 15 Missing ⚠️
compliance-api/src/compliance_api/auth.py 37.50% 10 Missing ⚠️
...ance-api/src/compliance_api/resources/apihelper.py 0.00% 10 Missing ⚠️
...liance-api/src/compliance_api/models/base_model.py 62.50% 6 Missing ⚠️
...liance-api/src/compliance_api/services/position.py 0.00% 5 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (252a5b3) and HEAD (94498d1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (252a5b3) HEAD (94498d1)
compliance-web 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
- Coverage    42.81%   36.00%   -6.81%     
===========================================
  Files           38       26      -12     
  Lines          334      661     +327     
  Branches        61        0      -61     
===========================================
+ Hits           143      238      +95     
- Misses         191      423     +232     
Flag Coverage Δ
compliance-api 36.00% <22.81%> (?)
compliance-web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dinesh-aot dinesh-aot merged commit 466a004 into bcgov:develop Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants