Merge pull request #1039 from bcgov/feature/ALCS-1175

Add Public NOI View
bcgov · Oct 10, 2023 · c3cffaf · c3cffaf
2 parents f766aa7 + e592a28
commit c3cffaf
Show file tree

Hide file tree

Showing 107 changed files with 3,172 additions and 443 deletions.
diff --git a/...t-submission/change-application-type-dialog/change-application-type-dialog.component.html b/...t-submission/change-application-type-dialog/change-application-type-dialog.component.html
@@ -55,7 +55,7 @@ <h5>Are you sure you want to change your application type?</h5>
     </div>
 
     <ng-container *ngIf="stepIdx === prescribedBodyStep">
-      <app-presribed-body [value]="prescribedBody" (select)="onSelectPrescribedBody($event)"></app-presribed-body>
+      <app-prescribed-body [value]="prescribedBody" (select)="onSelectPrescribedBody($event)"></app-prescribed-body>
     </ng-container>
   </div>
 </div>

diff --git a/...cations/view-submission/alc-review/submission-documents/submission-documents.component.ts b/...cations/view-submission/alc-review/submission-documents/submission-documents.component.ts
@@ -55,6 +55,4 @@ export class SubmissionDocumentsComponent implements OnInit, OnDestroy {
     this.$destroy.next();
     this.$destroy.complete();
   }
-
-  protected readonly open = open;
 }
diff --git a/...rontend/src/app/features/create-submission-dialog/create-submission-dialog.component.html b/...rontend/src/app/features/create-submission-dialog/create-submission-dialog.component.html
@@ -105,7 +105,7 @@ <h4 *ngIf="currentStep === steps.prescribedBody">
       </div>
     </ng-container>
     <ng-container *ngIf="currentStep === steps.prescribedBody">
-      <app-presribed-body (select)="onSelectPrescribedBody($event)"></app-presribed-body>
+      <app-prescribed-body (select)="onSelectPrescribedBody($event)"></app-prescribed-body>
     </ng-container>
     <ng-container *ngIf="currentStep === steps.srwType">
       <div class="step-description">

diff --git a/...lete-structure-confirmation-dialog/delete-structure-confirmation-dialog.component.spec.ts b/...lete-structure-confirmation-dialog/delete-structure-confirmation-dialog.component.spec.ts
@@ -1,3 +1,4 @@
+import { NO_ERRORS_SCHEMA } from '@angular/core';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { MatDialogRef } from '@angular/material/dialog';
 
@@ -9,10 +10,10 @@ describe('DeleteStructureConfirmationDialogComponent', () => {
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      declarations: [ DeleteStructureConfirmationDialogComponent ],
+      declarations: [DeleteStructureConfirmationDialogComponent],
       providers: [{ provide: MatDialogRef, useValue: {} }],
-    })
-    .compileComponents();
+      schemas: [NO_ERRORS_SCHEMA],
+    }).compileComponents();
 
     fixture = TestBed.createComponent(DeleteStructureConfirmationDialogComponent);
     component = fixture.componentInstance;

diff --git a/...ation/soil-removal-confirmation-dialog/soil-removal-confirmation-dialog.component.spec.ts b/...ation/soil-removal-confirmation-dialog/soil-removal-confirmation-dialog.component.spec.ts
@@ -1,3 +1,4 @@
+import { NO_ERRORS_SCHEMA } from '@angular/core';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { MatDialogRef } from '@angular/material/dialog';
 
@@ -11,6 +12,7 @@ describe('SoilRemovalConfirmationDialogComponent', () => {
     await TestBed.configureTestingModule({
       declarations: [SoilRemovalConfirmationDialogComponent],
       providers: [{ provide: MatDialogRef, useValue: {} }],
+      schemas: [NO_ERRORS_SCHEMA],
     }).compileComponents();
 
     fixture = TestBed.createComponent(SoilRemovalConfirmationDialogComponent);

diff --git a/...tures/notice-of-intents/notice-of-intent-details/pfrs-details/pfrs-details.component.html b/...tures/notice-of-intents/notice-of-intent-details/pfrs-details/pfrs-details.component.html
@@ -171,7 +171,6 @@
       ></app-no-data>
     </div>
   </div>
-
   <div class="subheading2 grid-1">Proposal Map / Site Plan</div>
   <div class="grid-double">
     <a *ngFor="let map of proposalMap" (click)="openFile(map.uuid)">
@@ -207,10 +206,10 @@
 
     <div class="subheading2 grid-1">Reclamation Plan</div>
     <div class="grid-double">
-      <a *ngFor="let file of crossSections" (click)="openFile(file.uuid)">
+      <a *ngFor="let file of reclamationPlans" (click)="openFile(file.uuid)">
         {{ file.fileName }}
       </a>
-      <app-no-data [showRequired]="showErrors" *ngIf="crossSections.length === 0"></app-no-data>
+      <app-no-data [showRequired]="showErrors" *ngIf="reclamationPlans.length === 0"></app-no-data>
     </div>
 
     <ng-container *ngIf="_noiSubmission.soilIsExtractionOrMining">

diff --git a/...es/notice-of-intents/notice-of-intent-details/pfrs-details/pfrs-details.component.spec.ts b/...es/notice-of-intents/notice-of-intent-details/pfrs-details/pfrs-details.component.spec.ts
@@ -5,7 +5,7 @@ import { NoticeOfIntentParcelService } from '../../../../services/notice-of-inte
 
 import { PfrsDetailsComponent } from './pfrs-details.component';
 
-describe('RosoDetailsComponent', () => {
+describe('PfrsDetailsComponent', () => {
   let component: PfrsDetailsComponent;
   let fixture: ComponentFixture<PfrsDetailsComponent>;
   let mockNoiDocumentService: DeepMocked<NoticeOfIntentDocumentService>;

diff --git a/...es/notice-of-intents/notice-of-intent-details/pofo-details/pofo-details.component.spec.ts b/...es/notice-of-intents/notice-of-intent-details/pofo-details/pofo-details.component.spec.ts
@@ -5,7 +5,7 @@ import { NoticeOfIntentParcelService } from '../../../../services/notice-of-inte
 
 import { PofoDetailsComponent } from './pofo-details.component';
 
-describe('RosoDetailsComponent', () => {
+describe('PofoDetailsComponent', () => {
   let component: PofoDetailsComponent;
   let fixture: ComponentFixture<PofoDetailsComponent>;
   let mockNoiDocumentService: DeepMocked<NoticeOfIntentDocumentService>;

diff --git a/...intents/view-submission/alc-review/submission-documents/submission-documents.component.ts b/...intents/view-submission/alc-review/submission-documents/submission-documents.component.ts
@@ -40,6 +40,4 @@ export class SubmissionDocumentsComponent implements OnInit, OnDestroy {
     this.$destroy.next();
     this.$destroy.complete();
   }
-
-  protected readonly open = open;
 }
diff --git a/...-survey-plan-confirmation-dialog/change-survey-plan-confirmation-dialog.component.spec.ts b/...-survey-plan-confirmation-dialog/change-survey-plan-confirmation-dialog.component.spec.ts
@@ -1,3 +1,4 @@
+import { NO_ERRORS_SCHEMA } from '@angular/core';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { MatDialogRef } from '@angular/material/dialog';
 
@@ -11,6 +12,7 @@ describe('ChangeSurveyPlanConfirmationDialogComponent', () => {
     await TestBed.configureTestingModule({
       declarations: [ChangeSurveyPlanConfirmationDialogComponent],
       providers: [{ provide: MatDialogRef, useValue: {} }],
+      schemas: [NO_ERRORS_SCHEMA],
     }).compileComponents();
 
     fixture = TestBed.createComponent(ChangeSurveyPlanConfirmationDialogComponent);

diff --git a/...cations/view-submission/alc-review/submission-documents/submission-documents.component.ts b/...cations/view-submission/alc-review/submission-documents/submission-documents.component.ts
@@ -47,6 +47,4 @@ export class SubmissionDocumentsComponent implements OnInit, OnDestroy {
     this.$destroy.next();
     this.$destroy.complete();
   }
-
-  protected readonly open = open;
 }
diff --git a/portal-frontend/src/app/features/public/application/alc-review/alc-review.component.ts b/portal-frontend/src/app/features/public/application/alc-review/alc-review.component.ts
@@ -1,7 +1,8 @@
 import { Component, Input } from '@angular/core';
 import { ApplicationPortalDecisionDto } from '../../../../services/application-decision/application-decision.dto';
 import { SUBMISSION_STATUS } from '../../../../services/application-submission/application-submission.dto';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../services/public/public.dto';
 
 @Component({
   selector: 'app-public-alc-review',

diff --git a/...ures/public/application/alc-review/submission-documents/submission-documents.component.ts b/...ures/public/application/alc-review/submission-documents/submission-documents.component.ts
@@ -2,7 +2,8 @@ import { Component, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';
 import { MatSort } from '@angular/material/sort';
 import { MatTableDataSource } from '@angular/material/table';
 import { Subject } from 'rxjs';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../../services/public/public.dto';
 import { PublicService } from '../../../../../services/public/public.service';
 
 @Component({
@@ -29,14 +30,14 @@ export class PublicSubmissionDocumentsComponent implements OnInit, OnDestroy {
   }
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res.url, '_blank');
     }
   }
 
   async downloadFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       const downloadLink = document.createElement('a');
       downloadLink.href = res.url;
@@ -54,6 +55,4 @@ export class PublicSubmissionDocumentsComponent implements OnInit, OnDestroy {
     this.$destroy.next();
     this.$destroy.complete();
   }
-
-  protected readonly open = open;
 }
diff --git a/portal-frontend/src/app/features/public/application/lfng-review/lfng-review.component.ts b/portal-frontend/src/app/features/public/application/lfng-review/lfng-review.component.ts
@@ -3,8 +3,8 @@ import { SUBMISSION_STATUS } from '../../../../services/application-submission/a
 import {
   PublicApplicationSubmissionDto,
   PublicApplicationSubmissionReviewDto,
-  PublicDocumentDto,
-} from '../../../../services/public/public.dto';
+} from '../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../services/public/public.dto';
 import { PublicService } from '../../../../services/public/public.service';
 import { DOCUMENT_TYPE } from '../../../../shared/dto/document.dto';
 
@@ -30,7 +30,7 @@ export class PublicLfngReviewComponent implements OnInit {
   }
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res.url, '_blank');
     }

diff --git a/portal-frontend/src/app/features/public/application/public-application.component.ts b/portal-frontend/src/app/features/public/application/public-application.component.ts
@@ -4,11 +4,10 @@ import { Subject, takeUntil } from 'rxjs';
 import { ApplicationPortalDecisionDto } from '../../../services/application-decision/application-decision.dto';
 import { SUBMISSION_STATUS } from '../../../services/application-submission/application-submission.dto';
 import {
-  PublicApplicationParcelDto,
   PublicApplicationSubmissionDto,
   PublicApplicationSubmissionReviewDto,
-  PublicDocumentDto,
-} from '../../../services/public/public.dto';
+} from '../../../services/public/public-application.dto';
+import { PublicDocumentDto, PublicParcelDto } from '../../../services/public/public.dto';
 import { PublicService } from '../../../services/public/public.service';
 
 @Component({
@@ -24,7 +23,7 @@ export class PublicApplicationComponent implements OnInit, OnDestroy {
   submission: PublicApplicationSubmissionDto | undefined;
   review: PublicApplicationSubmissionReviewDto | undefined;
   documents: PublicDocumentDto[] = [];
-  parcels: PublicApplicationParcelDto[] = [];
+  parcels: PublicParcelDto[] = [];
   decisions: ApplicationPortalDecisionDto[] = [];
 
   constructor(private publicService: PublicService, private route: ActivatedRoute) {}

diff --git a/portal-frontend/src/app/features/public/application/public-application.module.ts b/portal-frontend/src/app/features/public/application/public-application.module.ts
@@ -0,0 +1,62 @@
+import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
+import { MatAutocompleteModule } from '@angular/material/autocomplete';
+import { MatPaginatorModule } from '@angular/material/paginator';
+import { MatSortModule } from '@angular/material/sort';
+import { MatTreeModule } from '@angular/material/tree';
+import { RouterModule, Routes } from '@angular/router';
+import { SharedModule } from '../../../shared/shared.module';
+import { PublicAlcReviewComponent } from './alc-review/alc-review.component';
+import { PublicDecisionsComponent } from './alc-review/decisions/decisions.component';
+import { PublicSubmissionDocumentsComponent } from './alc-review/submission-documents/submission-documents.component';
+import { PublicLfngReviewComponent } from './lfng-review/lfng-review.component';
+import { PublicApplicationComponent } from './public-application.component';
+import { ExclDetailsComponent } from './submission/excl-details/excl-details.component';
+import { InclDetailsComponent } from './submission/incl-details/incl-details.component';
+import { NaruDetailsComponent } from './submission/naru-details/naru-details.component';
+import { NfuDetailsComponent } from './submission/nfu-details/nfu-details.component';
+import { ParcelComponent } from './submission/parcel/parcel.component';
+import { PfrsDetailsComponent } from './submission/pfrs-details/pfrs-details.component';
+import { PofoDetailsComponent } from './submission/pofo-details/pofo-details.component';
+import { RosoDetailsComponent } from './submission/roso-details/roso-details.component';
+import { SubdDetailsComponent } from './submission/subd-details/subd-details.component';
+import { SubmissionDetailsComponent } from './submission/submission-details.component';
+import { TurDetailsComponent } from './submission/tur-details/tur-details.component';
+
+const routes: Routes = [
+  {
+    path: ':fileId',
+    component: PublicApplicationComponent,
+  },
+];
+
+@NgModule({
+  declarations: [
+    PublicApplicationComponent,
+    PublicLfngReviewComponent,
+    PublicAlcReviewComponent,
+    PublicSubmissionDocumentsComponent,
+    PublicDecisionsComponent,
+    ParcelComponent,
+    SubmissionDetailsComponent,
+    NfuDetailsComponent,
+    TurDetailsComponent,
+    SubdDetailsComponent,
+    RosoDetailsComponent,
+    PofoDetailsComponent,
+    PfrsDetailsComponent,
+    NaruDetailsComponent,
+    ExclDetailsComponent,
+    InclDetailsComponent,
+  ],
+  imports: [
+    CommonModule,
+    SharedModule,
+    MatPaginatorModule,
+    MatSortModule,
+    RouterModule.forChild(routes),
+    MatAutocompleteModule,
+    MatTreeModule,
+  ],
+})
+export class PublicApplicationModule {}
diff --git a/...end/src/app/features/public/application/submission/excl-details/excl-details.component.ts b/...end/src/app/features/public/application/submission/excl-details/excl-details.component.ts
@@ -1,6 +1,7 @@
 import { Component, Input } from '@angular/core';
 import { Router } from '@angular/router';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../../services/public/public.dto';
 import { PublicService } from '../../../../../services/public/public.service';
 import { DOCUMENT_TYPE } from '../../../../../shared/dto/document.dto';
 
@@ -25,7 +26,7 @@ export class ExclDetailsComponent {
   constructor(private router: Router, private publicService: PublicService) {}
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res?.url, '_blank');
     }

diff --git a/...end/src/app/features/public/application/submission/incl-details/incl-details.component.ts b/...end/src/app/features/public/application/submission/incl-details/incl-details.component.ts
@@ -1,6 +1,7 @@
 import { Component, Input } from '@angular/core';
 import { Router } from '@angular/router';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../../services/public/public.dto';
 import { PublicService } from '../../../../../services/public/public.service';
 import { DOCUMENT_TYPE } from '../../../../../shared/dto/document.dto';
 
@@ -25,7 +26,7 @@ export class InclDetailsComponent {
   constructor(private router: Router, private publicService: PublicService) {}
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res?.url, '_blank');
     }

diff --git a/...end/src/app/features/public/application/submission/naru-details/naru-details.component.ts b/...end/src/app/features/public/application/submission/naru-details/naru-details.component.ts
@@ -1,6 +1,7 @@
 import { Component, Input } from '@angular/core';
 import { Router } from '@angular/router';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../../services/public/public.dto';
 import { PublicService } from '../../../../../services/public/public.service';
 import { DOCUMENT_TYPE } from '../../../../../shared/dto/document.dto';
 
@@ -20,7 +21,7 @@ export class NaruDetailsComponent {
   constructor(private router: Router, private publicService: PublicService) {}
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res?.url, '_blank');
     }

diff --git a/...ntend/src/app/features/public/application/submission/nfu-details/nfu-details.component.ts b/...ntend/src/app/features/public/application/submission/nfu-details/nfu-details.component.ts
@@ -1,6 +1,7 @@
 import { Component, Input } from '@angular/core';
 import { Router } from '@angular/router';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../../services/public/public.dto';
 import { PublicService } from '../../../../../services/public/public.service';
 import { DOCUMENT_TYPE } from '../../../../../shared/dto/document.dto';
 
@@ -21,7 +22,7 @@ export class NfuDetailsComponent {
   constructor(private router: Router, private publicService: PublicService) {}
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res?.url, '_blank');
     }

diff --git a/portal-frontend/src/app/features/public/application/submission/parcel/parcel.component.ts b/portal-frontend/src/app/features/public/application/submission/parcel/parcel.component.ts
@@ -1,7 +1,8 @@
 import { Component, Input } from '@angular/core';
 import { Subject } from 'rxjs';
 import { PARCEL_OWNERSHIP_TYPE } from '../../../../../services/application-parcel/application-parcel.dto';
-import { PublicApplicationParcelDto, PublicApplicationSubmissionDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicParcelDto } from '../../../../../services/public/public.dto';
 
 @Component({
   selector: 'app-parcel',
@@ -12,7 +13,7 @@ export class ParcelComponent {
   $destroy = new Subject<void>();
 
   @Input() applicationSubmission!: PublicApplicationSubmissionDto;
-  @Input() parcels: PublicApplicationParcelDto[] = [];
+  @Input() parcels: PublicParcelDto[] = [];
 
   PARCEL_OWNERSHIP_TYPES = PARCEL_OWNERSHIP_TYPE;
   pageTitle: string = 'Identify Parcel(s) Under Application';

diff --git a/...end/src/app/features/public/application/submission/pfrs-details/pfrs-details.component.ts b/...end/src/app/features/public/application/submission/pfrs-details/pfrs-details.component.ts
@@ -1,6 +1,7 @@
 import { Component, Input } from '@angular/core';
 import { Router } from '@angular/router';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../../services/public/public.dto';
 import { PublicService } from '../../../../../services/public/public.service';
 import { DOCUMENT_TYPE } from '../../../../../shared/dto/document.dto';
 
@@ -23,7 +24,7 @@ export class PfrsDetailsComponent {
   constructor(private router: Router, private publicService: PublicService) {}
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res?.url, '_blank');
     }

diff --git a/...end/src/app/features/public/application/submission/pofo-details/pofo-details.component.ts b/...end/src/app/features/public/application/submission/pofo-details/pofo-details.component.ts
@@ -1,6 +1,7 @@
 import { Component, Input } from '@angular/core';
 import { Router } from '@angular/router';
-import { PublicApplicationSubmissionDto, PublicDocumentDto } from '../../../../../services/public/public.dto';
+import { PublicApplicationSubmissionDto } from '../../../../../services/public/public-application.dto';
+import { PublicDocumentDto } from '../../../../../services/public/public.dto';
 import { PublicService } from '../../../../../services/public/public.service';
 import { DOCUMENT_TYPE } from '../../../../../shared/dto/document.dto';
 
@@ -23,7 +24,7 @@ export class PofoDetailsComponent {
   constructor(private router: Router, private publicService: PublicService) {}
 
   async openFile(uuid: string) {
-    const res = await this.publicService.getApplicationFileUrl(this.applicationSubmission.fileNumber, uuid);
+    const res = await this.publicService.getApplicationOpenFileUrl(this.applicationSubmission.fileNumber, uuid);
     if (res) {
       window.open(res?.url, '_blank');
     }