Decision outcome applications,noi public search #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaselhan
reviewed
Nov 8, 2023
...tures/public/search/notice-of-intent-search-table/notice-of-intent-search-table.component.ts
Outdated
Show resolved
Hide resolved
dhaselhan
reviewed
Nov 8, 2023
portal-frontend/src/app/features/public/search/public-search.component.ts
Outdated
Show resolved
Hide resolved
dhaselhan
reviewed
Nov 8, 2023
dhaselhan
reviewed
Nov 8, 2023
dhaselhan
reviewed
Nov 8, 2023
...es/apps/alcs/src/providers/typeorm/migrations/1699461885734-add_outcome_public_search_noi.ts
Outdated
Show resolved
Hide resolved
|
I don't see any updates to the mobile view, SearchListComponent, does it also need to be updated? |
* Fix bug with alrArea having wrong precision
dhaselhan
reviewed
Nov 16, 2023
...alcs/src/portal/public/search/notice-of-intent/public-notice-of-intent-search-view.entity.ts
Outdated
Show resolved
Hide resolved
dhaselhan
reviewed
Nov 16, 2023
services/apps/alcs/src/portal/public/search/public-search.controller.ts
Outdated
Show resolved
Hide resolved
dhaselhan
reviewed
Nov 20, 2023
| @@ -246,7 +249,7 @@ export class PublicSearchController { | |||
| localGovernmentName: notification.localGovernmentName, | |||
| ownerName: notification.applicant, | |||
| class: 'NOTI', | |||
| status: notification.status.status_type_code, | |||
| status: notification.status.status_type_code | |||
There was a problem hiding this comment.
This needs a prettier format I think. Looks like on some files your code is using a trailing comma but not all of them. For some reason on this file it looks like it IS NOT adding trailing commas.
"trailingComma": "all" is the prettier setting in the .prettierrc
dhaselhan
reviewed
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.