Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve portal accessibility errors and alerts #1149

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Resolve portal accessibility errors and alerts #1149

merged 8 commits into from
Nov 9, 2023

Conversation

sandratoh
Copy link
Contributor

@sandratoh sandratoh commented Nov 9, 2023 •
edited
Loading

  • Increase error color contrast in ALCS and Portal
  • Update Portal search expansion panel and user menu
  • Use mat-label for non-native input, textarea, or select elements to resolve label errors
  • Heading changes

@sandratoh sandratoh self-assigned this Nov 9, 2023
dhaselhan
dhaselhan approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Can you post in the Dev channel about using mat-label going forwards?

@sandratoh sandratoh merged commit 5a83236 into develop Nov 9, 2023
3 checks passed
@sandratoh sandratoh deleted the feature/ALCS-1290 branch November 9, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaselhan dhaselhan dhaselhan approved these changes

Assignees

@sandratoh sandratoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandratoh @dhaselhan