Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment PR - 935 #1400

Merged
merged 103 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
31a2bc6
add leading zero to PID (#1399)
mhuseinov Feb 8, 2024
2dc5670
Bug Fixes
Feb 8, 2024
57652ac
Merge pull request #1401 from bcgov/feature/ALCS-1641
dhaselhan Feb 8, 2024
e08fb2a
Bug Fixes
Feb 8, 2024
e6d5a99
Owner Fixes
Feb 8, 2024
f09a326
Merge pull request #1402 from bcgov/feature/ALCS-1662
dhaselhan Feb 8, 2024
17389f7
Merge pull request #1403 from bcgov/feature/ALCS-1663
dhaselhan Feb 8, 2024
2f9bde1
Add download file to ALC Review Tab for NOI
Feb 8, 2024
8a2a666
Fixes for ALCS edit submission (#1404)
sandratoh Feb 8, 2024
34a84d8
show pending visibility in documents table header
urmikgov Feb 8, 2024
7b8c027
Hide homesite severance
Feb 8, 2024
d17314f
Feature/alcs 1598 application under review (#1405)
mhuseinov Feb 8, 2024
bfe43a3
Merge pull request #1407 from bcgov/bugfix/alcs-1614
urmikgov Feb 8, 2024
ad1c0f6
Merge pull request #1406 from bcgov/feature/ALCS-1666
dhaselhan Feb 8, 2024
e5985ee
Merge pull request #1408 from bcgov/feature/ALCS-1580
dhaselhan Feb 8, 2024
301885b
Fix active days not showing in subtask list on home
trslater Feb 9, 2024
78d8327
fix 2 popovers on card
urmikgov Feb 9, 2024
65960be
documents to show pending on noi
urmikgov Feb 9, 2024
444130b
Merge pull request #1410 from bcgov/bugfix/alcs-1620
urmikgov Feb 12, 2024
21f6a9c
Merge pull request #1411 from bcgov/bugfix/alcs-1614
urmikgov Feb 12, 2024
3d40bbf
Reduce the number of times active days is retrieved
trslater Feb 12, 2024
11096b1
Add mock for NOI `getTimes` and test case for `activeDays`
trslater Feb 12, 2024
c15cbb7
Merge pull request #1409 from bcgov/bugfix/ALCS-1609
trslater Feb 12, 2024
43a9122
Update parcel confirmation dialog text (#1414)
sandratoh Feb 12, 2024
1efb108
Don't send email for In Progress Apps / NOIs
Feb 12, 2024
1c1dd48
Change ha to m^2 for NAUR decisions/proposal
trslater Feb 12, 2024
ee40b03
Merge pull request #1415 from bcgov/feature/ALCS-1571
dhaselhan Feb 12, 2024
f36583e
Add a display none uuid at the end of the footer
Feb 13, 2024
4381dcb
migration script for application and notice of intent applicants (#1413)
mhuseinov Feb 13, 2024
7e75f69
Merge pull request #1416 from bcgov/feature/ALCS-1671
trslater Feb 13, 2024
0b704cb
Clean up unused imports
trslater Feb 13, 2024
817e3ff
Merge pull request #1418 from bcgov/feature/ALCS-1595
dhaselhan Feb 13, 2024
d27e966
Add other parcel confirmation dialog
trslater Feb 13, 2024
b711ca6
Refactor NARU toggle to use booleans instead of strings
trslater Feb 13, 2024
c5e6379
Add NARU will fill confirmation dialog
trslater Feb 13, 2024
c248fe2
Rename NARU will fill dialog
trslater Feb 13, 2024
12d153d
Add NFU will fill dialog
trslater Feb 13, 2024
9ec3e6b
Update confirmation dialog tests
trslater Feb 13, 2024
413d083
unfocus assignee on select
urmikgov Feb 13, 2024
0cde6be
Fix other pacels test
trslater Feb 13, 2024
c914531
migration for purpose on application_submission (#1420)
mhuseinov Feb 13, 2024
5a8b831
Bugfix/alcs 1673 etl imported pdfs (#1417)
mhuseinov Feb 13, 2024
7345ff2
Merge pull request #1421 from bcgov/bugfix/alcs-1611
urmikgov Feb 13, 2024
54324a9
update parel mapping for applications
lstod Feb 13, 2024
741741b
Add optional title to portal dialog service
trslater Feb 14, 2024
d205b91
Replace other parcels/NFU/NARU dialogs with service
trslater Feb 14, 2024
f76454d
Merge pull request #1419 from bcgov/feature/ALCS-1562
trslater Feb 14, 2024
072bf0b
added extra space in applicant migration (#1423)
mhuseinov Feb 14, 2024
3464508
Blur field on selection 'waiting...'
trslater Feb 14, 2024
938103b
Fix typo
trslater Feb 14, 2024
ed75b84
revamped mapping
lstod Feb 14, 2024
fbe3eb2
Add Boundary Amendments
Feb 14, 2024
f11a54c
migration to reset REVG status if no review present (#1425)
mhuseinov Feb 14, 2024
64067ec
Merge pull request #1424 from bcgov/bugfix/ALCS-1616
trslater Feb 14, 2024
772a886
Only send email if it matches the current status
Feb 14, 2024
6533769
Preserve Whitespace in Review Tables
Feb 14, 2024
28d3030
Code Review Feedback
Feb 14, 2024
9ea1ea5
Merge pull request #1426 from bcgov/feature/ALCS-1371
dhaselhan Feb 15, 2024
d5be9a7
Merge pull request #1427 from bcgov/feature/ALCS-1678
dhaselhan Feb 15, 2024
5172640
500 character limit on duration, specific activity
urmikgov Feb 15, 2024
88eef9c
Boundary Amendments Pt2
Feb 15, 2024
5e5c089
Merge pull request #1431 from bcgov/feature/ALCS-1371
dhaselhan Feb 15, 2024
1a461b3
not using template variables
urmikgov Feb 15, 2024
e4e80a8
Move max length validations to dto
urmikgov Feb 15, 2024
ea9352f
Merge pull request #1428 from bcgov/feature/ALCS-1656
dhaselhan Feb 15, 2024
059cd80
Merge pull request #1430 from bcgov/task/alcs-1559
urmikgov Feb 15, 2024
b1c63d3
ALCS obfuscation 2.0 (#1429)
mhuseinov Feb 15, 2024
cc07e16
Merge pull request #1422 from bcgov/feature/ALCS-1612
lstod Feb 15, 2024
c6639f2
Fix assignee select not blurring for all scenarios
trslater Feb 15, 2024
ea9d782
disable organization name obfuscation (#1433)
mhuseinov Feb 15, 2024
8642e52
execute oats related migrations conditionally (#1434)
mhuseinov Feb 15, 2024
c793840
Merge pull request #1435 from bcgov/bugfix/ALCS-1611-QA
trslater Feb 20, 2024
f484be6
add missing semicolon and remove redundant code (#1436)
mhuseinov Feb 20, 2024
87e6f03
Bug Fixes
Feb 20, 2024
4185a64
Use Portal Healthcheck for Maintenance Mode
Feb 20, 2024
468f20c
Merge pull request #1437 from bcgov/feature/ALCS-1568
dhaselhan Feb 20, 2024
ea4ee64
Show Pending Document Flags when HideFromPortal On
Feb 20, 2024
777f0a6
Merge pull request #1438 from bcgov/feature/ALCS-1528
dhaselhan Feb 20, 2024
d400d65
Open card after creating
Feb 20, 2024
0bb084c
UI enhancements
urmikgov Feb 20, 2024
5c8bc14
Merge pull request #1439 from bcgov/feature/ALCS-1684
dhaselhan Feb 21, 2024
5964db6
Merge pull request #1440 from bcgov/feature/ALCS-1693
dhaselhan Feb 21, 2024
30416cd
init refactor of migration post launch
lstod Feb 21, 2024
f8e5c7c
fixes
urmikgov Feb 21, 2024
8e81376
Merge branch 'develop' of github.com:bcgov/alcs into task/alcs-1437
urmikgov Feb 21, 2024
147dbea
Update portal confirmation dialog UI and add check to structure type …
sandratoh Feb 21, 2024
1488ada
Merge pull request #1441 from bcgov/task/alcs-1437
urmikgov Feb 21, 2024
3571c1d
update README
lstod Feb 21, 2024
65b9239
remove missed line
lstod Feb 21, 2024
1d876b5
fix typo
lstod Feb 21, 2024
8057af0
remove etl log
lstod Feb 21, 2024
d7a569f
Merge pull request #1443 from bcgov/feature/ALCS-ETL-post-launch
lstod Feb 21, 2024
4e3d80c
Handling 500 character limit in PFRS
urmikgov Feb 21, 2024
39843b4
Merge pull request #1444 from bcgov/task/alcs-1559
urmikgov Feb 21, 2024
a97a0a5
Setup Typeorm Database Replication
Feb 21, 2024
a68d71c
Decision Date Fixes
Feb 22, 2024
6449f72
Merge pull request #1446 from bcgov/feature/ALCS-1707
dhaselhan Feb 22, 2024
63cb12c
Update Boundary Amendments
Feb 22, 2024
cbda039
Merge pull request #1448 from bcgov/feature/ALCS-1707
dhaselhan Feb 22, 2024
5c13466
Re-apply Hide from Portal for Pending Documents
Feb 22, 2024
b462c1c
Code Review Feedback
Feb 22, 2024
cc10ec5
Merge pull request #1450 from bcgov/feature/ALCS-1684-2
dhaselhan Feb 22, 2024
202f01d
Merge pull request #1445 from bcgov/feature/ALCS-1720
dhaselhan Feb 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ node_modules/
/test-results/
playwright-report/
playwright/.cache/
.~lock.*
.~lock.*

/ora2pg_data
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
padding: 16px;
margin: 24px 0 40px 0;
grid-template-columns: minmax(60px, 1fr) minmax(60px, 1fr) minmax(60px, 1fr) minmax(60px, 1fr);
white-space: pre-line;

.full-width {
grid-column: 1/5;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,14 @@
<div class="grid-double">
<span> {{ _applicationSubmission.subdIsHomeSiteSeverance ? 'Yes' : 'No' }}</span>
</div>
<div class="subheading2 grid-1">Proof of Homesite Severance Qualification</div>
<div class="grid-double">
<div *ngFor="let document of homesiteDocuments">
<a (click)="openFile(document)">
{{ document.fileName }}
</a>
<ng-container *ngIf="_applicationSubmission.subdIsHomeSiteSeverance">
<div class="subheading2 grid-1">Proof of Homesite Severance Qualification</div>
<div class="grid-double">
<div *ngFor="let document of homesiteDocuments">
<a (click)="openFile(document)">
{{ document.fileName }}
</a>
</div>
</div>
</div>
</ng-container>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@
[showStatus]="true"
[submissionStatusService]="applicationStatusService"
></app-details-header>
<div class="content">
<div class="content" *ngIf="application">
<div *ngIf="showSubmittedToAlcMenuItems" class="nav">
<div *ngFor="let route of childRoutes" class="nav-link">
<div
*ngIf="route.portalOnly ? isApplicantSubmission : true"
*ngIf="
(!route.portalOnly || isApplicantSubmission) &&
(route.appTypes ? route.appTypes.includes(application.type.code) : true)
"
[routerLink]="route.path ? route.path : './'"
routerLinkActive="active"
[routerLinkActiveOptions]="{ exact: route.path === '' }"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
import { SYSTEM_SOURCE_TYPES } from '../../shared/dto/system-source.types.dto';
import { ApplicantInfoComponent } from './applicant-info/applicant-info.component';
import { ApplicationMeetingComponent } from './application-meeting/application-meeting.component';
import { BoundaryAmendmentComponent } from './boundary-amendment/boundary-amendment.component';
import { decisionChildRoutes, DecisionModule } from './decision/decision.module';
import { DocumentsComponent } from './documents/documents.component';
import { InfoRequestsComponent } from './info-requests/info-requests.component';
Expand Down Expand Up @@ -148,6 +149,14 @@ export const appChildRoutes = [
component: PostDecisionComponent,
portalOnly: false,
},
{
path: 'boundary-amendments',
menuTitle: 'Boundary Amendments',
icon: 'border_style',
component: BoundaryAmendmentComponent,
portalOnly: false,
appTypes: ['INCL', 'EXCL'],
},
{
path: 'documents',
menuTitle: 'Documents',
Expand All @@ -164,7 +173,7 @@ export const appChildRoutes = [
})
export class ApplicationComponent implements OnInit, OnDestroy {
destroy = new Subject<void>();
childRoutes = appChildRoutes;
childRoutes: any = appChildRoutes;
unsubmittedRoutes = unsubmittedRoutes;
submittedLfngRoutes = submittedLfngRoutes;

Expand Down Expand Up @@ -224,7 +233,6 @@ export class ApplicationComponent implements OnInit, OnDestroy {
(s) => s.statusTypeCode === SUBMISSION_STATUS.SUBMITTED_TO_ALC && !!s.effectiveDate,
);
this.showSubmittedToLfngMenuItems = wasSubmittedToLfng && !submittedToAlcsStatus;

this.showSubmittedToAlcMenuItems = this.isApplicantSubmission ? !!submittedToAlcsStatus : true;
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ import { ApplicationMeetingDialogComponent } from './application-meeting/applica
import { ApplicationMeetingComponent } from './application-meeting/application-meeting.component';
import { CreateApplicationMeetingDialogComponent } from './application-meeting/create-application-meeting-dialog/create-application-meeting-dialog.component';
import { appChildRoutes, ApplicationComponent } from './application.component';
import { BoundaryAmendmentComponent } from './boundary-amendment/boundary-amendment.component';
import { EditBoundaryAmendmentDialogComponent } from './boundary-amendment/edit-boundary-amendment-dialog/edit-boundary-amendment-dialog.component';
import { DecisionModule } from './decision/decision.module';
import { DocumentUploadDialogComponent } from './documents/document-upload-dialog/document-upload-dialog.component';
import { DocumentsComponent } from './documents/documents.component';
import { InfoRequestsComponent } from './info-requests/info-requests.component';
import { InfoRequestDialogComponent } from './info-requests/info-rquest-dialog/info-request-dialog.component';
import { InfoRequestDialogComponent } from './info-requests/info-request-dialog/info-request-dialog.component';
import { IntakeComponent } from './intake/intake.component';
import { LfngInfoComponent } from './lfng-info/lfng-info.component';
import { ReturnApplicationDialogComponent } from './lfng-info/return-application-dialog/return-application-dialog.component';
Expand Down Expand Up @@ -82,6 +84,8 @@ const routes: Routes = [
ParcelPrepComponent,
UncancelApplicationDialogComponent,
ReturnApplicationDialogComponent,
BoundaryAmendmentComponent,
EditBoundaryAmendmentDialogComponent,
],
imports: [SharedModule, RouterModule.forChild(routes), ApplicationDetailsModule, DecisionModule],
})
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<div class="split">
<h3>ALR Boundary</h3>
<button mat-flat-button color="primary" (click)="onCreateAmendment()">+ Amendment</button>
</div>
<section>
<div *ngFor="let amendment of amendments; let i = index" class="amendment">
<div class="menu">
<button (click)="onEditAmendment(amendment)" matTooltip="Edit Amendment" mat-icon-button>
<mat-icon>edit</mat-icon>
</button>
<button (click)="onDeleteAmendment(amendment.uuid)" matTooltip="Delete Amendment" mat-icon-button>
<mat-icon>delete</mat-icon>
</button>
</div>
<div class="subheading1">Amendment #{{ amendments.length - i }}</div>
<div class="content">
<div class="full-grid-line">
<div class="subheading2">Amendment Type</div>
{{ amendment.type }}
</div>
<div>
<div class="subheading2">Decision Components</div>
<div *ngFor="let component of amendment.decisionComponents">
{{ component.label }}
</div>
</div>
<div>
<div class="subheading2">Area Included or Excluded (ha)</div>
<app-inline-number
[value]="amendment.area.toString()"
(save)="onSaveAlrArea(amendment.uuid, $event)"
[decimals]="5"
></app-inline-number>
</div>
<div>
<div class="subheading2">ALR Boundary Amendment Year</div>
<app-inline-dropdown
[value]="amendment.year?.toString()"
[options]="years"
(save)="onSaveYear(amendment.uuid, $event)"
/>
</div>
<div>
<div class="subheading2">ALR Boundary Amendment Period</div>
<app-inline-dropdown
[value]="amendment.period?.toString()"
[options]="periods"
(save)="onSavePeriod(amendment.uuid, $event)"
/>
</div>
</div>
</div>
</section>
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
@use '../../../../styles/colors';

section {
margin: 32px 0;
}

.amendment {
margin: 24px 0;
position: relative;
box-shadow: 0 2px 8px 1px rgba(0, 0, 0, 0.25);
padding: 32px;

.menu {
position: absolute;
top: 0;
right: 0;
height: 36px;
background: colors.$primary-color-dark;
box-shadow: -1px 1px 4px rgba(0, 0, 0, 0.25);
border-radius: 0 4px 0 10px;

button {
color: colors.$white;
width: 36px;
height: 36px;
line-height: 36px;
}

mat-icon {
position: absolute;
top: 8px;
left: 8px;
font-size: 21px;
width: 20px;
height: 36px;
}
}

.content {
margin-top: 16px;
margin-bottom: 32px;
display: grid;
grid-template-columns: 1fr 1fr;
grid-row-gap: 24px;
column-gap: 12px;

.subheading2 {
margin-bottom: 6px !important;
}

& > div {
font-size: 16px;
word-wrap: break-word;
}

.full-grid-line {
grid-column: 1 / 3;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
import { NO_ERRORS_SCHEMA } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { MatDialog } from '@angular/material/dialog';
import { createMock, DeepMocked } from '@golevelup/ts-jest';
import { BehaviorSubject } from 'rxjs';
import { ApplicationBoundaryAmendmentService } from '../../../services/application/application-boundary-amendments/application-boundary-amendment.service';
import { ApplicationDetailService } from '../../../services/application/application-detail.service';
import { ApplicationSubmissionStatusService } from '../../../services/application/application-submission-status/application-submission-status.service';
import { ApplicationTimelineService } from '../../../services/application/application-timeline/application-timeline.service';
import { ApplicationDto } from '../../../services/application/application.dto';

import { BoundaryAmendmentComponent } from './boundary-amendment.component';

describe('BoundaryAmendmentComponent', () => {
let component: BoundaryAmendmentComponent;
let fixture: ComponentFixture<BoundaryAmendmentComponent>;
let mockAppDetailService: DeepMocked<ApplicationDetailService>;

beforeEach(async () => {
mockAppDetailService = createMock();
mockAppDetailService.$application = new BehaviorSubject<ApplicationDto | undefined>(undefined);

await TestBed.configureTestingModule({
providers: [
{
provide: ApplicationDetailService,
useValue: mockAppDetailService,
},
{
provide: ApplicationBoundaryAmendmentService,
useValue: {},
},
{
provide: MatDialog,
useValue: {},
},
],
declarations: [BoundaryAmendmentComponent],
schemas: [NO_ERRORS_SCHEMA],
}).compileComponents();

fixture = TestBed.createComponent(BoundaryAmendmentComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

it('should create', () => {
expect(component).toBeTruthy();
});
});
Loading
Loading