ALCS obfuscation 2.0 #1429
Merged
ALCS obfuscation 2.0 #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstod
approved these changes
Feb 15, 2024
| fake.last_name(), | ||
| fake.company(), | ||
| fake.phone_number(), | ||
| "11@11", |
There was a problem hiding this comment.
It is somewhat common to use that email for testing. Should we leave this as 11@11, or would it be better to have something like obfuscated@email
There was a problem hiding this comment.
I'm using 11@11 as the default email since it will be 100% wrong and will not cause emails to be sent
| {get_update_column_query("department")}, | ||
| {get_update_column_query("phone_number")}, | ||
| {get_update_column_query("email")}, | ||
| {get_update_column_query("ocp_bylaw_name")}, |
There was a problem hiding this comment.
is ocp necessary to obfuscate? Name of bylaw isn't exactly identifiable info
There was a problem hiding this comment.
The problem with old data is that sometimes people put info into the wrong field. This field is free input and that is the reason why I'm obfuscating it
| {get_update_column_query("email")}, | ||
| {get_update_column_query("ocp_bylaw_name")}, | ||
| {get_update_column_query("ocp_designation")}, | ||
| {get_update_column_query("zoning_bylaw_name")}, |
There was a problem hiding this comment.
the same as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.