Keep organization name when changing from indv -> organization #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
May 23, 2024
dhaselhan
commented
- Also fixed a bug where the corporate summary was not getting deleted
* Also fixed a bug where the corporate summary was not getting deleted
sandratoh
reviewed
May 23, 2024
Comment on lines
+151
to
+157
| existingOwner.corporateSummaryUuid = null; | ||
| } | ||
|
|
||
| existingOwner.corporateSummaryUuid = | ||
| updateDto.corporateSummaryUuid !== undefined | ||
| ? updateDto.corporateSummaryUuid | ||
| : existingOwner.corporateSummaryUuid; | ||
| //Attach new one | ||
| if ( | ||
| updateDto.corporateSummaryUuid && | ||
| updateDto.corporateSummaryUuid !== existingOwner.corporateSummaryUuid |
There was a problem hiding this comment.
Wouldn't the previous if block change existingOwner.corporateSummaryUuid to be null, so this will always be true? Is it intentional to mutate it before this condition?
There was a problem hiding this comment.
Had call with Sandra to explain
Comment on lines
+166
to
+172
| existingOwner.corporateSummaryUuid = null; | ||
| } | ||
|
|
||
| existingOwner.corporateSummaryUuid = | ||
| updateDto.corporateSummaryUuid !== undefined | ||
| ? updateDto.corporateSummaryUuid | ||
| : existingOwner.corporateSummaryUuid; | ||
| //Attach new one | ||
| if ( | ||
| updateDto.corporateSummaryUuid && | ||
| updateDto.corporateSummaryUuid !== existingOwner.corporateSummaryUuid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.