-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter S3 Metadata in COMS data #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimCsaky
force-pushed
the
meta-tag-filter
branch
5 times, most recently
from
October 19, 2023 00:10
5094405
to
e884abc
Compare
TimCsaky
requested review from
jatindersingh93,
wilwong89,
kamorel and
jujaga
and removed request for
jujaga
October 19, 2023 00:11
TimCsaky
force-pushed
the
meta-tag-filter
branch
from
October 19, 2023 00:16
e884abc
to
3fccaf5
Compare
jujaga
reviewed
Oct 23, 2023
TimCsaky
force-pushed
the
meta-tag-filter
branch
2 times, most recently
from
October 23, 2023 18:57
43cb9ea
to
415bf22
Compare
kyle1morel
reviewed
Oct 23, 2023
TimCsaky
force-pushed
the
meta-tag-filter
branch
2 times, most recently
from
October 23, 2023 20:26
e131d59
to
0571065
Compare
kyle1morel
approved these changes
Oct 23, 2023
TimCsaky
force-pushed
the
meta-tag-filter
branch
2 times, most recently
from
October 23, 2023 21:39
e12b55a
to
a1941e6
Compare
jujaga
approved these changes
Oct 23, 2023
TimCsaky
force-pushed
the
meta-tag-filter
branch
from
October 23, 2023 23:05
a1941e6
to
17e66b4
Compare
jatindersingh93
approved these changes
Oct 24, 2023
TimCsaky
force-pushed
the
meta-tag-filter
branch
from
October 24, 2023 23:12
17e66b4
to
569ebe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3379
NOTE: we still need to decide on the actual keys we want to exclude. Maybe there's an easy way to update that in future.
general approach:
to test, add this to your local.json and clear browser session storage(existing config):
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments