-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRS-291-1: Convert A&R to use SAM #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidclaveau
requested review from
danieltruong,
cameronpettit,
marklise,
meredithom and
Christopher-walsh22
July 5, 2024 17:56
Remade PR after the previous one was accidentally merged and reverted here: #344 |
marklise
approved these changes
Jul 12, 2024
cameronpettit
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket:
BRS-291
BRS-322
BRS-323
BRS-342
BRS-343
Jira Ticket URL:
#291
#322
#323
#342
#343
Description:
Credentials in
env.js
to hit the Tools API from a local setup:# 291 - Move A&R to use SAM
A complete overhaul of the deployment strategy of BC Parks Attendance & Revenue API to use AWS's Serverless Application Model (SAM).
This includes migrating the functions into their equivalent SAM functions, changing util functions into applicable layers, converting/reintegrating tests to use SAM, and removing any Terraform legacy code
uses an Authorizer (
authorizer/index.js
) to process the JWT from Keycloak and create the necessary IAM roles for each functionsets up the API in API Gateway using the Authorizer
creates a new
ParksAr
,ConfigAr
, andNameCacheAr
tables in DynamoDBcreate a new S3 bucket for export assets
dependent on additional tickets (322, 323, 342, 343)
# 322 - Update Functions
package.json
files for each Lambda's required dependenciesevent
, as they are now decoded in the AuthorizerVarianceExportGetFunction
altered slightly to more closely resemble ExportGetFunction (was easier to debug during update).# 323 - Create Layers
utils
fileslogger
,sendResponse
, and the dynamoUtils file into aBaseLayer
file to circumvent the five-layer restriction set by AWSMakefile
s to build layers# 342 - Convert Tests
event
so roles/permissions are allocated in theheaders
of the tests# 343 - Cleanup Terraform and non-SAM Code
.github/wokflows
deploy actions to build and deploy the SAM files in each AWS environment