-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'dev' into 425-documents-ui
- Loading branch information
Showing
16 changed files
with
746 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
api/src/paths/administrative/submission/published.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| import chai, { expect } from 'chai'; | ||
| import { describe } from 'mocha'; | ||
| import sinon from 'sinon'; | ||
| import sinonChai from 'sinon-chai'; | ||
| import * as db from '../../../database/db'; | ||
| import { HTTPError } from '../../../errors/http-error'; | ||
| import { SECURITY_APPLIED_STATUS } from '../../../repositories/security-repository'; | ||
| import { SubmissionRecordWithSecurityAndRootFeatureType } from '../../../repositories/submission-repository'; | ||
| import { SubmissionService } from '../../../services/submission-service'; | ||
| import { getMockDBConnection, getRequestHandlerMocks } from '../../../__mocks__/db'; | ||
| import { getPublishedSubmissionsForAdmins } from './published'; | ||
|
|
||
| chai.use(sinonChai); | ||
|
|
||
| describe('getPublishedSubmissionsForAdmins', () => { | ||
| afterEach(() => { | ||
| sinon.restore(); | ||
| }); | ||
|
|
||
| it('re-throws any error that is thrown', async () => { | ||
| const mockDBConnection = getMockDBConnection({ | ||
| open: () => { | ||
| throw new Error('test error'); | ||
| } | ||
| }); | ||
|
|
||
| sinon.stub(db, 'getDBConnection').returns(mockDBConnection); | ||
|
|
||
| const { mockReq, mockRes, mockNext } = getRequestHandlerMocks(); | ||
|
|
||
| const requestHandler = getPublishedSubmissionsForAdmins(); | ||
|
|
||
| try { | ||
| await requestHandler(mockReq, mockRes, mockNext); | ||
| expect.fail(); | ||
| } catch (actualError) { | ||
| expect((actualError as HTTPError).message).to.equal('test error'); | ||
| } | ||
| }); | ||
|
|
||
| it('should return an array of Reviewed submission objects', async () => { | ||
| const dbConnectionObj = getMockDBConnection({ | ||
| commit: sinon.stub(), | ||
| rollback: sinon.stub(), | ||
| release: sinon.stub() | ||
| }); | ||
|
|
||
| sinon.stub(db, 'getDBConnection').returns(dbConnectionObj); | ||
|
|
||
| const mockResponse: SubmissionRecordWithSecurityAndRootFeatureType[] = [ | ||
| { | ||
| submission_id: 1, | ||
| uuid: '123-456-789', | ||
| security_review_timestamp: '2023-12-12', | ||
| submitted_timestamp: '2023-12-12', | ||
| publish_timestamp: '2023-12-12', | ||
| source_system: 'SIMS', | ||
| name: 'name', | ||
| description: 'description', | ||
| create_date: '2023-12-12', | ||
| create_user: 1, | ||
| update_date: null, | ||
| update_user: null, | ||
| revision_count: 0, | ||
| security: SECURITY_APPLIED_STATUS.SECURED, | ||
| root_feature_type_id: 1, | ||
| root_feature_type_name: 'dataset' | ||
| }, | ||
| { | ||
| submission_id: 2, | ||
| uuid: '789-456-123', | ||
| security_review_timestamp: '2023-12-12', | ||
| submitted_timestamp: '2023-12-12', | ||
| source_system: 'SIMS', | ||
| publish_timestamp: '2023-12-12', | ||
| name: 'name', | ||
| description: 'description', | ||
| create_date: '2023-12-12', | ||
| create_user: 1, | ||
| update_date: '2023-12-12', | ||
| update_user: 1, | ||
| revision_count: 1, | ||
| security: SECURITY_APPLIED_STATUS.PARTIALLY_SECURED, | ||
| root_feature_type_id: 1, | ||
| root_feature_type_name: 'dataset' | ||
| } | ||
| ]; | ||
|
|
||
| const { mockReq, mockRes, mockNext } = getRequestHandlerMocks(); | ||
|
|
||
| const getReviewedSubmissionsStub = sinon | ||
| .stub(SubmissionService.prototype, 'getPublishedSubmissionsForAdmins') | ||
| .resolves(mockResponse); | ||
|
|
||
| const requestHandler = getPublishedSubmissionsForAdmins(); | ||
|
|
||
| await requestHandler(mockReq, mockRes, mockNext); | ||
|
|
||
| expect(getReviewedSubmissionsStub).to.have.been.calledOnce; | ||
| expect(mockRes.statusValue).to.equal(200); | ||
| expect(mockRes.jsonValue).to.eql(mockResponse); | ||
| }); | ||
| }); |
Oops, something went wrong.