split dataloaders for submission record/features

[KjartanE]

Overview

Links to Jira tickets

• {List all applicable Jira tickets}

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohub-platform-app-215-a0ec71-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohub-platform-api-215-a0ec71-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/a0ec71-dev/pods?name=215

[sonarqubecloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (400ab9e) 62.60% compared to head (298d450) 62.66%.
Report is 4 commits behind head on dataset_security_feature.

Files	Patch %	Lines
app/src/contexts/submissionContext.tsx	0.00%	7 Missing ⚠️
...atures/submissions/components/SubmissionHeader.tsx	0.00%	5 Missing ⚠️
...p/src/features/submissions/AdminSubmissionPage.tsx	0.00%	2 Missing ⚠️
app/src/hooks/api/useSubmissionsApi.ts	50.00%	2 Missing ⚠️
.../paths/submission/{submissionId}/features/index.ts	95.23%	0 Missing and 1 partial ⚠️
api/src/services/submission-service.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                     Coverage Diff                      @@
##           dataset_security_feature     #215      +/-   ##
============================================================
+ Coverage                     62.60%   62.66%   +0.06%     
============================================================
  Files                           258      259       +1     
  Lines                          6992     7029      +37     
  Branches                       1006     1011       +5     
============================================================
+ Hits                           4377     4405      +28     
- Misses                         2377     2386       +9     
  Partials                        238      238              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NickPhura]

Only gave it a static look over but looks good to me.